Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove proj_def.dat (#201) #1210

Merged
merged 3 commits into from Dec 27, 2018

Conversation

Projects
None yet
2 participants
@rouault
Copy link
Member

rouault commented Dec 27, 2018

This also fixes a regression recently added in PROJ master now that cs2cs is using underneath the new ISO19111 code to generate pipeline, which doesn't emit +no_defs, and thus cause issues with CRS using LCC_1SP projections that erroneously use the lat_2=45 default of proj_def.dat

rouault added some commits Dec 27, 2018

operation proj=merc
accept 0 0
expect 0 0
expect failure errno major_axis_not_given

This comment has been minimized.

@kbevers

kbevers Dec 27, 2018

Member

Is this because we now don't have a default ellipsoid?

This comment has been minimized.

@rouault

rouault Dec 27, 2018

Author Member

yes

This comment has been minimized.

@kbevers

kbevers Dec 27, 2018

Member

I guess that would leave many projections default-less with regards to ellipsoids. It seems to me that +proj=merc not working without adding +ellps=... is a step in the wrong direction. I think setting ellipsoid parameters for GRS80 when initialising a PJ would be a sane default. If +ellps=bessel (or whatever) is set it will obviously be overridden.

This comment has been minimized.

@rouault

rouault Dec 27, 2018

Author Member

OK, default to ellps=GRS80 per 6bb14fa

@kbevers

This comment has been minimized.

Copy link
Member

kbevers commented Dec 27, 2018

Looks good to me!

@kbevers kbevers merged commit 1230114 into OSGeo:master Dec 27, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@kbevers kbevers added this to the 6.0.0 milestone Dec 27, 2018

kbevers referenced this pull request Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.