Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong parameter in ITRF2000 to ITRF2005 transfomations #1240

Merged
merged 2 commits into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@keyos89
Copy link
Contributor

keyos89 commented Jan 29, 2019

There seems to be one zero too much in the ds-parameter.
http://itrf.ign.fr/ITRF_solutions/2005/tp_05-00.php

@kbevers

This comment has been minimized.

Copy link
Member

kbevers commented Jan 29, 2019

Hej Karoline, nice catch! I believe you are correct. It seems we are using those exact numbers in a test case. Please also adjust the value here:

proj.4/test/unit/test_io.cpp

Lines 8676 to 8684 in 62799e1

auto obj =
PROJStringParser().createFromPROJString("init=ITRF2000:ITRF2005");
auto co = nn_dynamic_pointer_cast<CoordinateOperation>(obj);
ASSERT_TRUE(co != nullptr);
EXPECT_EQ(co->exportToPROJString(PROJStringFormatter::create().get()),
"+proj=helmert +x=-0.0001 +y=0.0008 +z=0.0058 +s=-0.0004 "
"+dx=0.0002 +dy=-0.0001 +dz=0.0018 +ds=-0.000008 "
"+t_epoch=2000.0 +convention=position_vector");
}

(i think that's the only place tests needs to be adjusted).

Update test with correct parameter
Update ds to be in correspondence with ITRF2000 file
@rouault

This comment has been minimized.

Copy link
Member

rouault commented Jan 29, 2019

+1 This fix also agrees with EPSG:

$ src/projinfo -s ITRF2000 -t ITRF2005 -o PROJ
unknown id, Conversion from ITRF2000 (geog3D) to ITRF2000 (geocentric) + ITRF2000 to ITRF2005 (1) + Conversion from ITRF2005 (geocentric) to ITRF2005 (geog3D), 0.01 m, World

PROJ string:
+proj=pipeline +step +proj=axisswap +order=2,1 +step +proj=unitconvert +xy_in=deg +z_in=m +xy_out=rad +z_out=m +step +proj=cart +ellps=GRS80 +step +proj=helmert +x=-0.0001 +y=0.0008 +z=0.0058 +rx=0 +ry=0 +rz=0 +s=-0.0004 +dx=0.0002 +dy=-0.0001 +dz=0.0018 +drx=0 +dry=0 +drz=0 +ds=-8e-05 +t_epoch=2000 +convention=position_vector +step +inv +proj=cart +ellps=GRS80 +step +proj=unitconvert +xy_in=rad +z_in=m +xy_out=deg +z_out=m +step +proj=axisswap +order=2,1

@kbevers

This comment has been minimized.

Copy link
Member

kbevers commented Jan 29, 2019

Yes, this was simply a typo on my part. Thanks for fixing it @keyos89!

@kbevers kbevers merged commit 824b278 into OSGeo:master Jan 29, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 84.553%
Details

@kbevers kbevers added this to the 6.0.0 milestone Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.