Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Some improvements to the docs for tmerc and omerc #1281
kbevers left a comment
Overall this is very good. I would suggest only keeping the first paragraph ("The Oblique Mercator projection is a cylindrical map projection that closes the
There's some good figures in #523. I don't know the source of the figures but if we are allowed to include them (or reproductions of them) I think they would help illustrate some of the points made about he different types of rotations that can be applied. It's probably a job for another day but at least it is worth considering this as a future improvement.
Not as related as I expected when starting the work: While omerc clearly being mostly in need of a touch up, I thought of it as an occasion for a general overhaul of omerc, tmerc, and merc, giving an overall better feeling that they are in close family, although looking much different.
I think I got part of that message through in the intro to omerc, but I ran short of time before getting through everything.
So, yes, it was the idea to make changes logically tied across all 3 projections, but that is probably not terribly evident from this PR.