Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1st eccentricity instead of 2nd eccentricity #1324

Merged
merged 1 commit into from Mar 16, 2019

Conversation

Projects
None yet
1 participant
@kbevers
Copy link
Member

commented Mar 16, 2019

By mistake the second eccentricity was used in a few places in the
Molodensky transform. According to the literature the first eccentricity
should always be used in the eccentricity.

This only affects the output slightly. Reported test coordinates
differed by less than a millimeter.

Fixes #1321

@kbevers kbevers referenced this pull request Mar 16, 2019

Merged

Various ossfuzz fixes #1322

Use 1st eccentricity instead of 2nd eccentricity
By mistake the second eccentricity was used in a few places in the
Molodensky transform. According to the literature the first eccentricity
should always be used in the eccentricity.

This only affects the output slightly. Reported test coordinates
differed by less than a millimeter.

Fixes #1321

@kbevers kbevers force-pushed the kbevers:molodensky-eccentricity branch from d5f0213 to 644a592 Mar 16, 2019

@kbevers

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2019

Travis fail caused by error in doc generation. Taken care of in https://github.com/OSGeo/proj.4/pull/1325/files

@kbevers kbevers merged commit eab2279 into OSGeo:master Mar 16, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 85.254%
Details

@kbevers kbevers added this to the 6.0.1 milestone Mar 16, 2019

@kbevers kbevers deleted the kbevers:molodensky-eccentricity branch Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.