Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proj_create_crs_to_crs: better deal with coordinates outside of bbox (fixes #1329) #1333

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
2 participants
@rouault
Copy link
Member

commented Mar 19, 2019

In case several coordinate operations are returned for a CRS to CRS transformation,
we currently determine the one to use by selecting the first operation whose
bounding box contains the input point.

This commit adds a fallback case where after doing that first iteration and finding
no appropriate candidate, we try again by selecting the first operation available
that does not involve grid based transformations.

proj_create_crs_to_crs: better deal with coordinates outside of bbox (f…
…ixes #1329)

In case several coordinate operations are returned for a CRS to CRS transformation,
we currently determine the one to use by selecting the first operation whose
bounding box contains the input point.

This commit adds a fallback case where after doing that first iteration and finding
no appropriate candidate, we try again by selecting the first operation available
that does not involve grid based transformations.
@kbevers

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

This seems like the most sensible thing to do. Thanks for taking care of this.

@kbevers kbevers merged commit 42b9332 into OSGeo:master Mar 19, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.001%) to 85.3%
Details

@backporting backporting bot referenced this pull request Mar 19, 2019

Merged

Backport #1333 on 6.0 #1334

rouault added a commit that referenced this pull request Mar 20, 2019

@kbevers kbevers added this to the 6.0.1 milestone Mar 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.