Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: automatically enable system error messages #1336

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
3 participants
@cjmayo
Copy link
Contributor

commented Mar 20, 2019

Define HAVE_STRERROR from configure.

Before:

$ cs2cs +proj=latlong +to +proj=latlong dummy
<cs2cs>:
Sys errno: 2: <system mess. texts unavail.>
dummy

After:

$ cs2cs +proj=latlong +to +proj=latlong dummy
<cs2cs>:
Sys errno: 2: No such file or directory
dummy

Tested against 6.0.0, and 5.2.0.

@kbevers

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Nice catch. Please apply the same fix to the CMake setup as well, so that build with either system works the same.

Build: automatically enable system error messages
Define HAVE_STRERROR during configuration.

Before:
$ cs2cs +proj=latlong +to +proj=latlong dummy
<cs2cs>:
Sys errno: 2: <system mess. texts unavail.>
dummy

After:
$ cs2cs +proj=latlong +to +proj=latlong dummy
<cs2cs>:
Sys errno: 2: No such file or directory
dummy

@cjmayo cjmayo force-pushed the cjmayo:strerror branch from 090a36c to ddd333e Mar 21, 2019

@cjmayo cjmayo changed the title Automatically enable system error messages using Autotools Build: automatically enable system error messages Mar 21, 2019

@cjmayo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

Added CMake support.

@kbevers kbevers added this to the 6.0.1 milestone Mar 22, 2019

@kbevers kbevers merged commit f8ba1db into OSGeo:master Mar 22, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 85.266%
Details
@backporting

This comment has been minimized.

Copy link

commented Mar 22, 2019

The backport to 6.0 failed:

Commits ["ddd333e6bd6f5e033a2b829067910165e64eb0b9"] could not be cherry-picked on top of 6.0
@kbevers

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Added CMake support.

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.