Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cs2cs support 4D coordinates. #1355

Merged
merged 1 commit into from Mar 24, 2019

Conversation

Projects
None yet
2 participants
@kbevers
Copy link
Member

commented Mar 24, 2019

This is a bit of a hack, 4D coordinates will be written to STDOUT
but the output format speficied with -f is not respected for the
t component, rather it is forward verbatim from the input.

Fixes #1354

@rouault
Copy link
Member

left a comment

Perhaps a test in test/cli/testvarious

Show resolved Hide resolved src/apps/cs2cs.cpp Outdated
Make cs2cs support 4D coordinates.
This is a bit of a hack, 4D coordinates *will* be written to STDOUT
but the output format speficied with -f is not respected for the
t component, rather it is forward verbatim from the input.

Fixes #1354

@kbevers kbevers force-pushed the kbevers:cs2cs-4d branch from b820692 to 10e1b7b Mar 24, 2019

@kbevers

This comment has been minimized.

Copy link
Member Author

commented Mar 24, 2019

Perhaps a test in test/cli/testvarious

Done.

@kbevers

This comment has been minimized.

Copy link
Member Author

commented Mar 24, 2019

To be honest, this is not an ideal fix but it will work for the foreseeable future. The proper fix is to rewrite cs2cs more or less completely and have it be 4D by default. A good candidate for a breaking change introduced with PROJ 7.

@kbevers kbevers added this to the 6.0.1 milestone Mar 24, 2019

@kbevers kbevers merged commit 4f78797 into OSGeo:master Mar 24, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.001%) to 85.279%
Details

kbevers added a commit that referenced this pull request Mar 24, 2019

Merge pull request #1357 from OSGeo/backport-1355-on-6.0
Backport #1355 on 6.0: Make cs2cs support 4D coordinates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.