Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that ISO19111 C++ code sets pj_errno on errors #1405

Merged
merged 1 commit into from Apr 2, 2019

Conversation

Projects
None yet
1 participant
@kbevers
Copy link
Member

commented Apr 2, 2019

As mentioned on the mailing list, proj_create() doesn't set the error number when an error is created. This also applies to many other functions in src\iso19111\c_api.cpp. Fixed in this PR.

I've added a new error code, PJD_ERR_GENERIC_ERROR, which will be set if no other errno is applied when an exception is raised. This applies to all functions in src\iso19111\c_api.cpp that calls proj_log_error() (which btw is badly named since it is not publicly accessible - should be pj_log_error()).

@kbevers kbevers force-pushed the kbevers:return_errno_proj_create branch from c6c088b to 6a41d46 Apr 2, 2019

@kbevers kbevers changed the title proj_create(): set pj_errno when error is raised Make sure that ISO19111 C++ code sets pj_errno on errors Apr 2, 2019

@kbevers kbevers added this to the 6.1.0 milestone Apr 2, 2019

@kbevers kbevers force-pushed the kbevers:return_errno_proj_create branch from 6a41d46 to 20300c1 Apr 2, 2019

@kbevers kbevers merged commit c0d91bd into OSGeo:master Apr 2, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.002%) to 85.409%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.