Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make nad2bin output reproducible. #381

Merged
merged 1 commit into from May 23, 2016
Merged

Make nad2bin output reproducible. #381

merged 1 commit into from May 23, 2016

Conversation

sebastic
Copy link
Contributor

As reported by Alexis Bienvenüe in ​Debian Bug #825088:

While working on the reproducible builds effort, we have noticed that the nad2bin binary has unreproducible output, as it includes uninitialized memory state when CTABLE.id's length is less than the available 80 bytes.

This issue in nad2bin is one of causes for unreproducible builds of GRASS as reported in Debian Bug #825092 and illustrated in its diffoscope output.

@sebastic
Make nad2bin output reproducible.
11f9737 
Init CTABLE.id char[80] variable with zeroes, so that nad2bin output does
not depend on memory state before call, and hence be reproducible.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.396% when pulling 11f9737 on sebastic:nad2bin-reproducible-header into 8b4c079 on OSGeo:master.

@rouault rouault merged commit a112ea3 into OSGeo:master May 23, 2016
@rouault
Copy link
Member

rouault commented May 23, 2016

Thanks

@sebastic sebastic deleted the nad2bin-reproducible-header branch May 23, 2016 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebastic @coveralls @rouault