New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust adjlon to use canonical M_PI defines #665

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
1 participant
@busstoptaktik
Member

busstoptaktik commented Nov 14, 2017

A year or so ago, @micahcochran put quite some effort into rationalizing the PI usage in PROJ.4, by ensuring that a number of useful M_PI related constants were defined in projects.h.

But apparently adjlon.c was left behind still using its own set of definitions - perhaps because it bends the values slightly, to avoid unwanted sign switching near the date line.

I have now reimplemented the "bending trick" to use the rationalized M_PI constants only.

@busstoptaktik busstoptaktik self-assigned this Nov 14, 2017

@busstoptaktik busstoptaktik merged commit cff58ea into OSGeo:master Nov 15, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 72.954%
Details

@busstoptaktik busstoptaktik deleted the busstoptaktik:adjlon-pi branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment