New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove angle brackets for proj headers #849

Merged
merged 2 commits into from Mar 11, 2018

Conversation

Projects
None yet
2 participants
@busstoptaktik
Member

busstoptaktik commented Mar 9, 2018

Using angle brackets in include directives increases the risk of accidentally picking up an older system installed header file while building an updated version of PROJ.

This PR changes the angle brackets to "" for proj.h, projects.h, proj_api.h and geodesic.h

Resolves #841.

busstoptaktik added some commits Mar 9, 2018

Avoid using angle brackets for PROJ headers.
Switching from #include <proj.h> to #include "proj.h",
and correspondingly for projects.h and proj_api.h,
reduces the risk of accidentally picking up a system
installed older version of the header while building
a new version of PROJ.

@kbevers kbevers added this to the 5.0.1 milestone Mar 9, 2018

@kbevers kbevers merged commit ab87b8e into OSGeo:master Mar 11, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 75.675%
Details

kbevers added a commit that referenced this pull request Mar 11, 2018

Remove angle brackets for proj headers (#849)
* Avoid using angle brackets for PROJ headers.

Switching from #include <proj.h> to #include "proj.h",
and correspondingly for projects.h and proj_api.h,
reduces the risk of accidentally picking up a system
installed older version of the header while building
a new version of PROJ.

* Also handle geodesic.h
@kbevers

This comment has been minimized.

Member

kbevers commented Mar 11, 2018

Cherry-picked into 5.0 branch

@busstoptaktik busstoptaktik deleted the busstoptaktik:remove_angle_brackets_for_proj_headers branch Mar 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment