New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gie.c: Initialize test_time other fields. #902

Merged
merged 1 commit into from Mar 26, 2018

Conversation

Projects
None yet
2 participants
@schwehr
Contributor

schwehr commented Mar 26, 2018

Leaving x, y, z fields unset triggers an MSAN failure.

fwd_prepare pj_fwd.c:40:9
pj_fwd4d pj_fwd.c:260:15
proj_trans proj_4D_api.c:166:20
test_time gie.c:1955:11

src/gie.c Outdated
@@ -1950,6 +1950,9 @@ static int test_time(const char* args, double tol, double t_in, double t_exp) {
if (P == 0)
return 5;

in.xyzt.x = 0.0;

This comment has been minimized.

@kbevers

kbevers Mar 26, 2018

Member

How about in = proj_coord(0, 0, 0, t_in); for a simpler initialization?

This comment has been minimized.

@schwehr

schwehr Mar 26, 2018

Contributor

Thanks! Done.

Initialize test_time other fields.
Leaving x, y, z fields unset triggers an MSAN failure.

fwd_prepare pj_fwd.c:40:9
pj_fwd4d    pj_fwd.c:260:15
proj_trans  proj_4D_api.c:166:20
test_time   gie.c:1955:11

@schwehr schwehr force-pushed the schwehr:gie-time branch from 51d7e27 to 4ac0f38 Mar 26, 2018

@kbevers kbevers added this to the 5.1.0 milestone Mar 26, 2018

@kbevers kbevers merged commit a1d9245 into OSGeo:master Mar 26, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 75.757%
Details

@schwehr schwehr deleted the schwehr:gie-time branch Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment