{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":684014805,"defaultBranch":"main","name":"flake-pilot","ownerLogin":"OSInside","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2023-08-28T09:16:01.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/44779941?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717687621.0","currentOid":""},"activityList":{"items":[{"before":"1bff68e47596c91fabb203297ba49c2bf4231a3b","after":"1b030b37cd099a3fb4d73a9703f21cddb2084c99","ref":"refs/heads/main","pushedAt":"2024-06-10T08:46:26.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Merge pull request #45 from OSInside/fix_inefficient_to_owned\n\nMake clippy happy","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2338533062\" data-permission-text=\"Title is private\" data-url=\"https://github.com/OSInside/flake-pilot/issues/45\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/OSInside/flake-pilot/pull/45/hovercard\" href=\"https://github.com/OSInside/flake-pilot/pull/45\">#45</a> from OSInside/fix_inefficient_to_owned"}},{"before":null,"after":"af23bc7d86a49efb94984d8b2fb6936a6eb573fa","ref":"refs/heads/fix_inefficient_to_owned","pushedAt":"2024-06-06T15:27:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Make clippy happy\n\nassigning the result of `ToOwned::to_owned()` may be inefficient","shortMessageHtmlLink":"Make clippy happy"}},{"before":"8b04397e1020934fb59a96b21f3c5353c9e381c8","after":"1bff68e47596c91fabb203297ba49c2bf4231a3b","ref":"refs/heads/main","pushedAt":"2024-06-06T15:02:16.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Bump version: 3.0.12 → 3.0.13","shortMessageHtmlLink":"Bump version: 3.0.12 → 3.0.13"}},{"before":"adc970a71bfe411d46f4837ab3c7f0020f5f7f12","after":null,"ref":"refs/heads/set_terminal_output_flags","pushedAt":"2024-04-10T10:55:09.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"}},{"before":"17e5460635dfd973ff37cd6d6928a9b6e89a3407","after":"8b04397e1020934fb59a96b21f3c5353c9e381c8","ref":"refs/heads/main","pushedAt":"2024-04-10T10:55:05.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Merge pull request #44 from OSInside/set_terminal_output_flags\n\nTurn terminal flag setup into function","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2235231447\" data-permission-text=\"Title is private\" data-url=\"https://github.com/OSInside/flake-pilot/issues/44\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/OSInside/flake-pilot/pull/44/hovercard\" href=\"https://github.com/OSInside/flake-pilot/pull/44\">#44</a> from OSInside/set_terminal_output_flags"}},{"before":null,"after":"adc970a71bfe411d46f4837ab3c7f0020f5f7f12","ref":"refs/heads/set_terminal_output_flags","pushedAt":"2024-04-10T10:14:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Turn terminal flag setup into function","shortMessageHtmlLink":"Turn terminal flag setup into function"}},{"before":"58d0b6c2b964bade517411fc7dda10037db60498","after":"17e5460635dfd973ff37cd6d6928a9b6e89a3407","ref":"refs/heads/main","pushedAt":"2024-04-10T07:54:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Bump version: 3.0.11 → 3.0.12","shortMessageHtmlLink":"Bump version: 3.0.11 → 3.0.12"}},{"before":"26ce54f63eade762dee2bb062560e97e003c9a34","after":null,"ref":"refs/heads/fix_non_resume_mode_exit_condition","pushedAt":"2024-04-10T07:54:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"}},{"before":"6b279f78e0cacd015de3e28ee0d2c63f2935aad8","after":null,"ref":"refs/heads/sci_terminal_settings","pushedAt":"2024-04-10T07:53:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"}},{"before":"bc4ff29ebd7ab5d6423cc7138dfd28eaf0e75c47","after":"58d0b6c2b964bade517411fc7dda10037db60498","ref":"refs/heads/main","pushedAt":"2024-04-10T07:53:20.000Z","pushType":"pr_merge","commitsCount":4,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Merge pull request #43 from OSInside/sci_terminal_settings\n\nAdd terminal settings for pty stdout in sci","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2233612794\" data-permission-text=\"Title is private\" data-url=\"https://github.com/OSInside/flake-pilot/issues/43\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/OSInside/flake-pilot/pull/43/hovercard\" href=\"https://github.com/OSInside/flake-pilot/pull/43\">#43</a> from OSInside/sci_terminal_settings"}},{"before":"605add0e3fdc67c594c9ab79a40b780077f71c09","after":"bc4ff29ebd7ab5d6423cc7138dfd28eaf0e75c47","ref":"refs/heads/main","pushedAt":"2024-04-10T07:51:43.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Merge pull request #42 from OSInside/fix_non_resume_mode_exit_condition\n\nFix invalid early exit condition","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2233134933\" data-permission-text=\"Title is private\" data-url=\"https://github.com/OSInside/flake-pilot/issues/42\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/OSInside/flake-pilot/pull/42/hovercard\" href=\"https://github.com/OSInside/flake-pilot/pull/42\">#42</a> from OSInside/fix_non_resume_mode_exit_condition"}},{"before":"b96366f42076a4b150fd36253c9ac7160531beee","after":"6b279f78e0cacd015de3e28ee0d2c63f2935aad8","ref":"refs/heads/sci_terminal_settings","pushedAt":"2024-04-10T07:31:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Fix race condition on connection check","shortMessageHtmlLink":"Fix race condition on connection check"}},{"before":"76d6ec0e99b656ee8fa999f7335527a3d5e579ba","after":"b96366f42076a4b150fd36253c9ac7160531beee","ref":"refs/heads/sci_terminal_settings","pushedAt":"2024-04-09T16:50:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Fix race condition on connection check","shortMessageHtmlLink":"Fix race condition on connection check"}},{"before":"3adb7c54156224b937ef62191b7c6e962d04ac03","after":"76d6ec0e99b656ee8fa999f7335527a3d5e579ba","ref":"refs/heads/sci_terminal_settings","pushedAt":"2024-04-09T16:43:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Fix race condition on connection check","shortMessageHtmlLink":"Fix race condition on connection check"}},{"before":"1b01dfa2532f1344304603da3f9089e5b43719cd","after":"3adb7c54156224b937ef62191b7c6e962d04ac03","ref":"refs/heads/sci_terminal_settings","pushedAt":"2024-04-09T14:53:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"set PS1 prompt via sci env","shortMessageHtmlLink":"set PS1 prompt via sci env"}},{"before":null,"after":"1b01dfa2532f1344304603da3f9089e5b43719cd","ref":"refs/heads/sci_terminal_settings","pushedAt":"2024-04-09T14:42:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Add terminal settings for pty stdout in sci\n\ndisable ECHO","shortMessageHtmlLink":"Add terminal settings for pty stdout in sci"}},{"before":null,"after":"26ce54f63eade762dee2bb062560e97e003c9a34","ref":"refs/heads/fix_non_resume_mode_exit_condition","pushedAt":"2024-04-09T10:35:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Fix invalid early exit condition","shortMessageHtmlLink":"Fix invalid early exit condition"}},{"before":"e1091e8dca9438422cd25fc484046952f26adc50","after":"605add0e3fdc67c594c9ab79a40b780077f71c09","ref":"refs/heads/main","pushedAt":"2024-04-08T11:02:28.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Bump version: 3.0.10 → 3.0.11","shortMessageHtmlLink":"Bump version: 3.0.10 → 3.0.11"}},{"before":"75a4e565a76132c836017ca6d31e50b4d57ada77","after":null,"ref":"refs/heads/get_rid_of_socat","pushedAt":"2024-04-08T10:40:08.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"}},{"before":"97951313948237a7474c7208bb5a98aaf798c715","after":"e1091e8dca9438422cd25fc484046952f26adc50","ref":"refs/heads/main","pushedAt":"2024-04-08T10:40:05.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Merge pull request #41 from OSInside/get_rid_of_socat\n\nPrevent use of socat in firecracker-pilot","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2229842269\" data-permission-text=\"Title is private\" data-url=\"https://github.com/OSInside/flake-pilot/issues/41\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/OSInside/flake-pilot/pull/41/hovercard\" href=\"https://github.com/OSInside/flake-pilot/pull/41\">#41</a> from OSInside/get_rid_of_socat"}},{"before":"221f2286cee00a107a2b5b9cc38f53145ee0a1a8","after":"75a4e565a76132c836017ca6d31e50b4d57ada77","ref":"refs/heads/get_rid_of_socat","pushedAt":"2024-04-07T16:36:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Prevent use of socat in firecracker-pilot\n\nDo not shell out socat and use proper UnixListener/UnixStream\nto do this job. This version of the commit works but I stumbled\nacross a few issues:\n\n1. Permission denied when the UnixListener runs as user and the\n   firecracker process was called as root (run_as: root in the flake).\n   The former implementation ran socat via sudo in the same way as\n   the firecracker process. Thus if you register the flake to\n   run as root it can now also only be called as root, which is\n   acceptable.\n\n2. The behavior in interactive sessions differs compared to socat.\n   When sci in the guest is called it creates a pty and all data\n   is copied to the vsock stream. The host connects via an UDS\n   socket to this data and we multiplex stdin->stream and\n   stream->stdout. When doing this with socat the behavior\n   is different in a way that e.g tabs are effectively interpreted\n   and the pty prompt allows for input on the same line when\n   my code now always needs a newline to renew the prompt.\n   I did not debug further what is needed to make this look\n   nicer.\n\nThis Fixes #8","shortMessageHtmlLink":"Prevent use of socat in firecracker-pilot"}},{"before":"d83870bc7c734afd114fad1b7730086deea4e797","after":"221f2286cee00a107a2b5b9cc38f53145ee0a1a8","ref":"refs/heads/get_rid_of_socat","pushedAt":"2024-04-07T16:30:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Prevent use of socat in firecracker-pilot\n\nDo not shell out socat and use proper UnixListener/UnixStream\nto do this job. This version of the commit works but I stumbled\nacross a few issues:\n\n1. Permission denied when the UnixListener runs as user and the\n   firecracker process was called as root (run_as: root in the flake).\n   The former implementation ran socat via sudo in the same way as\n   the firecracker process. Thus if you register the flake to\n   run as root it can now also only be called as root, which is\n   acceptable.\n\n2. The behavior in interactive sessions differs compared to socat.\n   When sci in the guest is called it creates a pty and all data\n   is copied to the vsock stream. The host connects via an UDS\n   socket to this data and we multiplex stdin->stream and\n   stream->stdout. When doing this with socat the behavior\n   is different in a way that e.g tabs are effectively interpreted\n   and the pty prompt allows for input on the same line when\n   my code now always needs a newline to renew the prompt.\n   I did not debug further what is needed to make this look\n   nicer.","shortMessageHtmlLink":"Prevent use of socat in firecracker-pilot"}},{"before":"f5661d2375aacbd1bf5b6a373555ce82cedf3e96","after":"d83870bc7c734afd114fad1b7730086deea4e797","ref":"refs/heads/get_rid_of_socat","pushedAt":"2024-04-07T16:05:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"space fixes","shortMessageHtmlLink":"space fixes"}},{"before":"e7bcb49056062750970f16a4285243dec12e91e2","after":"f5661d2375aacbd1bf5b6a373555ce82cedf3e96","ref":"refs/heads/get_rid_of_socat","pushedAt":"2024-04-07T14:44:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Listener error handling","shortMessageHtmlLink":"Listener error handling"}},{"before":"e1e59495310c40bdf73e5c567654d2f67fc80f5d","after":"e7bcb49056062750970f16a4285243dec12e91e2","ref":"refs/heads/get_rid_of_socat","pushedAt":"2024-04-07T14:38:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"clippy fixes\n\nComplete now but there are issues:\n\n1. Permission denied when the UnixListener runs as user and the\n   firecracker process was called as root. The former implementation\n   ran socat via sudo in the same way as the firecracker process\n\n2. An extra return is needed to show the prompt in interactive\n   sessions. Don't know how socat solved this","shortMessageHtmlLink":"clippy fixes"}},{"before":"9d31014b80c5851c71cdbf08115cf32ac51aaf59","after":"e1e59495310c40bdf73e5c567654d2f67fc80f5d","ref":"refs/heads/get_rid_of_socat","pushedAt":"2024-04-07T13:54:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"only one connection","shortMessageHtmlLink":"only one connection"}},{"before":"64cee6a747734aa3e12e8790e0bedc9b2bb11a05","after":"9d31014b80c5851c71cdbf08115cf32ac51aaf59","ref":"refs/heads/get_rid_of_socat","pushedAt":"2024-04-05T13:03:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Untested UnixListener in Thread\n\nThis Fixes #8","shortMessageHtmlLink":"Untested UnixListener in Thread"}},{"before":"beade287dc87d72f3d746fd7b592f56e15052540","after":"64cee6a747734aa3e12e8790e0bedc9b2bb11a05","ref":"refs/heads/get_rid_of_socat","pushedAt":"2024-04-05T12:06:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Untested UnixListener in Thread","shortMessageHtmlLink":"Untested UnixListener in Thread"}},{"before":"26341b118538cbd6c13e959ca5557d59e1f96feb","after":"beade287dc87d72f3d746fd7b592f56e15052540","ref":"refs/heads/get_rid_of_socat","pushedAt":"2024-04-04T20:06:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"Delete socat from spec","shortMessageHtmlLink":"Delete socat from spec"}},{"before":"bb8e872ba6e5d51ad96308ed074a69ce63b6c9f5","after":"26341b118538cbd6c13e959ca5557d59e1f96feb","ref":"refs/heads/get_rid_of_socat","pushedAt":"2024-04-04T20:05:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"schaefi","name":"Marcus Schäfer","path":"/schaefi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/912234?s=80&v=4"},"commit":{"message":"vsock_uds_path full permissions","shortMessageHtmlLink":"vsock_uds_path full permissions"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEYOHIyAA","startCursor":null,"endCursor":null}},"title":"Activity · OSInside/flake-pilot"}