Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Show progress information on box download" #39

Closed
wants to merge 1 commit into from

Conversation

Conan-Kudo
Copy link
Member

python-wget is a dead module and we should not depend on it.

This reverts commit 4227ebb.

python-wget is a dead module and we should not depend on it.

This reverts commit 4227ebb.
@Conan-Kudo
Copy link
Member Author

@schaefi I haven't merged this yet, because we should figure out what we want to replace this with...

But I've applied a variant of this patch downstream in Fedora: https://src.fedoraproject.org/rpms/kiwi-boxed-plugin/c/4b65617c815f44fb7c0f643b2626993d10ec35b6

@schaefi
Copy link
Contributor

schaefi commented Jun 22, 2021

Hmm, ok. I think I should have done a better research.

The module is pretty handy to use and could be easily integrated. Other options are

  • progressbar
  • tqdm

Using those needs more code as they are only progress bars not downloaders. I have no problem coding this but I prefer the most simple solution... if upstream supported

Thoughts / Alternatives ?

@Conan-Kudo
Copy link
Member Author

urlgrabber is progressbar+downloader and is not completely dead.

@schaefi
Copy link
Contributor

schaefi commented Jun 22, 2021

I'm using the progressbar module now. Please review #40

As there is already a requirement to the requests module I only replaced the wget requirement with progressbar.
The progressbar module seems to be maintained code and at least on suse I also see a package for it

@schaefi
Copy link
Contributor

schaefi commented Jun 23, 2021

closing on behalf of #40

@schaefi schaefi closed this Jun 23, 2021
@Conan-Kudo Conan-Kudo deleted the revert-pywget-dep branch June 23, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants