Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort filesystem listings #672

Merged
merged 1 commit into from Feb 11, 2019
Merged

Sort filesystem listings #672

merged 1 commit into from Feb 11, 2019

Conversation

bmwiedemann
Copy link
Contributor

Sort filesystem listings
so that kiwi works in a reproducible way
in spite of indeterministic filesystem readdir order.

See https://reproducible-builds.org/ for why this is good.

so that kiwi works in a reproducible way
in spite of indeterministic filesystem readdir order.

See https://reproducible-builds.org/ for why this is good.
@davidcassany
Copy link
Collaborator

Former kiwi is in maintenance mode and only alive in SLE12 series and in Leap 42.3. Unless it is known to cause some specific issues, in general, I would be more in favor of not touching this code. The change does not look too intrusive to me so we could probably merge it here, but I doubt if this deserves a specific backport to SLE.

@schaefi any thoughts regarding that?

@schaefi
Copy link
Collaborator

schaefi commented Feb 11, 2019

I agree, we can merge this change, Thanks Bernhard for the work but we won't be porting this to SLE12 unless there is a customer L3 report available.

@davidcassany feel free to merge

@davidcassany davidcassany merged commit 166cd36 into OSInside:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants