Sort filesystem listings #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmwiedemann
commented
Feb 10, 2019
kiwi/iso_tools/cdrtools.py
Outdated
| @@ -250,7 +250,8 @@ def _create_sortfile(self): | |||
| boot_files = list(os.walk(self.source_dir + '/' + self.boot_path)) | |||
| boot_files += list(os.walk(self.source_dir + '/EFI')) | |||
| for basedir, dirnames, filenames in boot_files: | |||
| for filename in filenames: | |||
| #dirnames.sort() # TODO - seems to break mocking | |||
There was a problem hiding this comment.
left this for now. One workaround is to write it as dirnames=sorted(dirnames)
but IMHO fixing the tests would be better
bmwiedemann
force-pushed
the
sort
branch
2 times, most recently
from
da06561
to
4eab151
Compare
schaefi
requested changes
Feb 11, 2019
schaefi
approved these changes
Feb 11, 2019
|
I'm fine with the changes and will merge the PR once the conflict got resolved. Thanks |
using tox -v -e unit_py2_7 -- -vv ./test/unit/iso_tools_cdrtools_test.py
so that kiwi works in a reproducible way in spite of indeterministic filesystem readdir order and http://bugs.python.org/issue30461 See https://reproducible-builds.org/ for why this is good.
|
resolved. |
|
yes that's nice, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Change proposed in this pull request:
Sort filesystem listings
so that kiwi works in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461
See https://reproducible-builds.org/ for why this is good.
Notes: