Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MVBS calculation based on either time or ping number #54

Closed
leewujung opened this issue Jul 13, 2019 · 2 comments
Closed

MVBS calculation based on either time or ping number #54

leewujung opened this issue Jul 13, 2019 · 2 comments
Assignees
@leewujung
Milestone
0.5.0 release

Comments

@leewujung
Copy link
Member

leewujung commented Jul 13, 2019 •
edited
Loading

The get_MVBS method should have options to average based on either ping number (current) or ping time (not implemented yet), like below:

# Average based on time
EchoData.get_MVBS(average_type='time', MVBS_time_bin=time)  # time : timedelta
# Average based on ping numbers
EchoData.get_MVBS(average_type='ping', MVBS_ping_bin=ping_size)  # ping_size : int

It should also accommodate averaging across the file boundaries when many consecutive files were collected in a mission. This requires using xarray.open_mfdataset. Most likely also need to look into efficiency issue re. chunking and invoking dask correctly.
@leewujung leewujung changed the title MVBS calculation improvement Improving MVBS calculation based on either time or ping number Oct 17, 2019
@leewujung leewujung mentioned this issue Nov 28, 2019
Closed
2 tasks
@leewujung leewujung added this to the parallelization of basic processing functionalities milestone Dec 10, 2019
@leewujung leewujung changed the title Improving MVBS calculation based on either time or ping number MVBS calculation based on either time or ping number Dec 10, 2019
@leewujung leewujung assigned leewujung and unassigned prarobinson Jan 4, 2020
@leewujung leewujung mentioned this issue Jun 29, 2020
Closed
@leewujung leewujung modified the milestones: Parallelizing basic processing functionalities, Parallelizing functions in process Jul 29, 2020
@leewujung leewujung modified the milestones: Parallelizing functions in process, Process upgrade, 0.5.1 release Dec 19, 2020
@leewujung
Copy link
Member Author

This is now implemented in preprocess as compute_MVBS and compute_MVBS_index_binning in #295.

@leewujung
Copy link
Member Author

Closing this with #298.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leewujung leewujung

Labels
None yet
Projects
None yet
Milestone
0.5.0 release
Development

No branches or pull requests
2 participants
@prarobinson @leewujung