Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brackets are missing for single values in the OSCQuery JSON #395

Closed
bltzr opened this Issue May 14, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@bltzr
Copy link
Member

bltzr commented May 14, 2018

as mentioned in #386

brackets are still missing for single values in the OSCQuery JSON:

from my ossia-cpp app:
"size" : {
"ACCESS" : 3,
"FULL_PATH" : "/renderer/size",
"RANGE" : {
"MAX" : 100,
"MIN" : 0
},
"TYPE" : "f",
"VALUE" : 28.571399688720703
}
from VVOSCQueryServer:
"my_float" : {
"ACCESS" : 3,
"DESCRIPTION" : "test float node",
"FULL_PATH" : "/test/my_float",
"RANGE" : [
{
"MAX" : 100,
"MIN" : 0
}
],
"TYPE" : "f",
},
The spec example shows brackets, and the spec tells that:

RANGE The value stored at this string is an array
So I guess we need brackets, as they are the JSON marker for an array, aren't they ?

@bltzr

This comment has been minimized.

Copy link
Member Author

bltzr commented Jul 21, 2018

as reported on http://forum.ossia.io/t/issue-in-oscquery-implementation/77 this apparently breaks compatibility with other OSCquery implementations, which is a bit of a pity

would you have the time to have a look into it @jcelerier ?

I believe there was an issue with RANGE as well, isn't it ?

@mattbeghin

This comment has been minimized.

Copy link

mattbeghin commented Jul 21, 2018

I tried to control MadMapper (version 3.3) with Score and all values non array values have value "0" (rgba colours are ok for instance) because of this issue. It's easy to support both notations so you keep compatibilty with existing projects.

@jcelerier jcelerier added the protocols label Jul 26, 2018

@jcelerier

This comment has been minimized.

Copy link
Member

jcelerier commented Jul 30, 2018

hmm, I thought that this proposal had been merged but it looks like it's not the case: Vidvox/OSCQueryProposal#35

@jcelerier jcelerier closed this in 3e91fbc Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.