Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ossia-max] parameter : default value is not fired at object creation #441

Closed
matcham opened this issue Sep 6, 2018 · 16 comments

Comments

@matcham
Copy link

commented Sep 6, 2018

(issue in ossia-max v 1.0.0 ; did work fine in release from a couple of weeks ago)

open ossia.parameter.maxhelp
default value is not fired at loading
(sending reset DO works)

@matcham matcham added the bug label Sep 6, 2018

@matcham matcham added this to the release/1.0 milestone Sep 6, 2018

@jln-

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2018

That's not a bug, that's a feature ! :-)

@jcelerier

This comment has been minimized.

Copy link
Member

commented Sep 7, 2018

@jln- hmm maybe it should be in the doc or as a comment in the max patch ?

@bltzr

This comment has been minimized.

Copy link
Member

commented Sep 7, 2018

@matcham

This comment has been minimized.

Copy link
Author

commented Sep 7, 2018

seriously, it's a feature ?
help patch says "Parameters can be set a default value, fired at loading"
and it used to work this way until now. If you decided to change it recently, I would be curious to know what motivated this decision :-)

@jln-

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2018

Sorry guys, it was a joke (I'm just often annoyed by this default value firing).

Haven't check with lastest release yet but indeed default value get sent on loading with previous release. So if it's not the case now, indeed something broke.

@bltzr

This comment has been minimized.

Copy link
Member

commented Sep 9, 2018

could that be related to the change you did to fix #377 ?

@bltzr

This comment has been minimized.

Copy link
Member

commented Sep 9, 2018

@avilleret

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2018

what does not work ?
here with build SHA : 8ade368, the test patcher 312-default_broken.maxtest.maxpat works as expected
so i'm closing it now, please reopen with a test patcher if problem persist

@avilleret avilleret closed this Sep 15, 2018

@jln-

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2018

@avilleret It seems OK most of the time but I see that sometimes, default value do not get fired. Steps to reproduce:

  • make an ossia.parameter in a blank patcher
  • alt-click ossia.parameter object to open maxhelp
  • close maxhelp
  • alt-click again to open maxhelp

Doing this a few time then comes a time where parameter do not get initialized.

This is with a fresh build of libossia.

test_init 2018-09-15 14_53_53

@jln- jln- reopened this Sep 15, 2018

@matcham

This comment has been minimized.

Copy link
Author

commented Sep 16, 2018

for me, with latest release (1.0.1) : default value is never fired.
open ossia.parameter.maxhelp :
ossia.parameter my_loadmess @type float @default 1.23
do not output anything at loading

@jln-

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2018

@matcham I'll zip you version I built yesterday so you can test

@matcham

This comment has been minimized.

Copy link
Author

commented Sep 16, 2018

@jln- if you say that it doesn't work, I believe you :-)

@jln-

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2018

Well, most of the time it works... I did not see it not working but when intentionally opening/closing again and again.

@avilleret avilleret closed this in c8ab4bd Sep 17, 2018

avilleret added a commit that referenced this issue Sep 17, 2018

@avilleret

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2018

according to https://github.com/OSSIA/libossia/blob/master/OSSIA/ossia-max/max-test/441-multi_load.maxtest.maxpat it's working

please improve the test patcher until it doesn't work again :-)

@matcham

This comment has been minimized.

Copy link
Author

commented Sep 21, 2018

in latest release (v 1.0.1) : it (kind of) work on Mac (as @jln- described)
but it doesn't work at all in windows. (default value is never fired)

But maybe you already fixed it, so I'll wait for the next release (as I can't build myself..)
@avilleret or @jcelerier : if you have a fresh windows build, I can test it.

@bltzr

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

as reported here:
http://forum.ossia.io/t/ossia-parameter-is-losing-its-value-when-ossia-model-changes-its-address/126
default values are not fired when created (only when loaded)
this is a different bug, but I guess it's related so reopening, retitling and updating this one

@bltzr bltzr reopened this Feb 15, 2019

@bltzr bltzr changed the title [ossia-max] parameter : default value is not fired at loading [ossia-max] parameter : default value is not fired at object creation Feb 15, 2019

@avilleret avilleret closed this in d4cfb57 Apr 18, 2019

avilleret added a commit that referenced this issue Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.