Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDID "YUV" fixes #31

Merged
merged 14 commits into from
Sep 4, 2019
Merged

EDID "YUV" fixes #31

merged 14 commits into from
Sep 4, 2019

Conversation

rpavlik
Copy link
Member

@rpavlik rpavlik commented Aug 29, 2019

This does a few things:

  • Moves the original EDID data into an editable JSON format (including the tools to convert to binary - xxd is used to convert to header)
  • Removed the incorrect "YUV supported!" flag from the EDIDs of HDK2SVR and HDK 1.3/4, which may have been causing compat issues.

@rpavlik rpavlik mentioned this pull request Aug 29, 2019
Open
godbyk
godbyk approved these changes Aug 30, 2019
View reviewed changes
Copy link

@godbyk godbyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, check that you mean to include the generated files (edid.h and .bin). Otherwise, this looks good to me.

Source code/Embedded/src/Variants/HDK_20/edid.h Show resolved Hide resolved
Source code/Embedded/vendor/cros-chameleon/edid/basic_display.py Show resolved Hide resolved
@rpavlik
Copy link
Member Author

rpavlik commented Aug 30, 2019 •
edited
Loading

Thanks for the review kevin 😁 you're awesome. Think I might do the truly-bizarre and cut a release...

@rpavlik rpavlik merged commit 4279936 into master Sep 4, 2019
@rpavlik rpavlik deleted the hdk2yuvfix branch September 4, 2019 17:52
@rpavlik rpavlik added this to the 2.01 milestone Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godbyk godbyk godbyk approved these changes

@VRguy VRguy Awaiting requested review from VRguy

@JeroMiya JeroMiya Awaiting requested review from JeroMiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.01
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rpavlik @godbyk