Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working draft of custom profile icons #65

Merged
merged 2 commits into from Nov 27, 2018

Conversation

Projects
None yet
2 participants
@bblarney
Copy link
Contributor

commented Nov 16, 2018

Referencing issue #33

I wouldn't merge this PR as is, just made it to prove I actually have some work done so far haha

I added a file input button to the top nav bar, if you click that and upload a picture it will be displayed rather than the default icon.

Things that need to be added/changed:
-Need to send the avatar so other chatters will see it, as part of the message?
-Should the avatar selection be on the chat page or on the login page? Seemed easier to make on the chat page, and can change whenever you want
-Better button styling so its obvious what the upload is for
-Resize the image a bit better

Appreciate any input on this

bblarney and others added some commits Nov 16, 2018

@joshghent

This comment has been minimized.

Copy link
Collaborator

commented Nov 27, 2018

Awesome work @bblarney - great work! 🎉 Hope to see you around again soon. Thanks for your contribution

@joshghent joshghent merged commit b24c258 into OTRChat:master Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.