Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in NodeJS Cheat Sheet #399

Merged
merged 3 commits into from Jun 1, 2020
Merged

Fix typo in NodeJS Cheat Sheet #399

merged 3 commits into from Jun 1, 2020

Conversation

@notsoshant
Copy link
Contributor

@notsoshant notsoshant commented May 30, 2020

Fix a typo in X-Frame-Options helmet code

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as TEXT
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR covers issue #.

Thank you again for your contribution 😃

Copy link
Contributor

@ThunderSon ThunderSon left a comment

Thanks for spotting that!

@ThunderSon
Copy link
Contributor

@ThunderSon ThunderSon commented May 31, 2020

Would you be able to resolve the conflicts? It's the file name that changed. Let me know if you need help :)

@notsoshant
Copy link
Contributor Author

@notsoshant notsoshant commented Jun 1, 2020

Resolved the conflict. Please check.

@rbsec
rbsec approved these changes Jun 1, 2020
Copy link
Contributor

@rbsec rbsec left a comment

Looks good, thanks.

@rbsec rbsec merged commit 2233ae0 into OWASP:master Jun 1, 2020
2 of 3 checks passed
2 of 3 checks passed
link-check link-check
Details
lint
Details
Publishing Check
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants