Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update threatmodeling cs #404

Merged
merged 3 commits into from Jun 18, 2020

Conversation

@ThunderSon
Copy link
Contributor

@ThunderSon ThunderSon commented Jun 3, 2020

This is a buildup to the uplift of the threat modeling CS, based on issue #300 and this does not close the issue.
This PR is a starting point to add some peripherals to the CS.

The PR should be reviewed against the content in place, and not in what it could be missing.
For what is missing and needs to be done, this will be discussed in the issue mentioned.

ThunderSon added 2 commits Jun 3, 2020
@ThunderSon ThunderSon requested review from mackowski and rbsec as code owners Jun 3, 2020
@ThunderSon
Copy link
Contributor Author

@ThunderSon ThunderSon commented Jun 3, 2020

@swierckx and @ben-dale your comments are welcome as a starting point for the CS.

@ThunderSon ThunderSon self-assigned this Jun 3, 2020
@ben-dale
Copy link
Contributor

@ben-dale ben-dale commented Jun 5, 2020

Your change made me double-take because it's basically the outline I started hashing out the other day (but never got a chance to push it up) so I wondered how you got hold of it 😂

The only difference was the headings I used (subject to change). The idea being that the CS could discuss each heading with the DOs and DONTs:

## Threat modeling an application
There are four key questions that form the basis of most threat modeling methodologies:
- What are we building?
- What can go wrong?
- What are we going to do about it?
- Did we do a good enough job?

### Understand what you are building
DOs/DONTs from Question 1
https://2018.open-security-summit.org/outcomes/tracks/threat-model/working-sessions/tm-cheatsheets/

### Determine what could go wrong
A section to outline steps
DOs/DONTs from Question 2
https://2018.open-security-summit.org/outcomes/tracks/threat-model/working-sessions/tm-cheatsheets/

### Identify the remediations
DOs/DONTs from Question 3
https://2018.open-security-summit.org/outcomes/tracks/threat-model/working-sessions/tm-cheatsheets/

### Validate your assumptions and share your findings
DOs/DONTs from Question 4
https://2018.open-security-summit.org/outcomes/tracks/threat-model/working-sessions/tm-cheatsheets/

I wasn't 100% on some of the DOs and DONTs, for example "DON’T Confuse can and should". I wasn't sure exactly what that meant.

I also had a section which mentioned some tools, but all I had was OWASP Threat Dragon. I'm not sure on OWASP's stance on recommending commercial tools like Miro etc.

@jmanico
Copy link
Member

@jmanico jmanico commented Jun 5, 2020

@ThunderSon
Copy link
Contributor Author

@ThunderSon ThunderSon commented Jun 7, 2020

Hahaha I have my ways.

I believe the difference is perspective. Are you thinking in the headings to be actionable, or to help run the session? They're pretty similar. I set them as such to follow the flow in the questions asked, and not confuse the reader. What you did is flesh out what's happening.

For the tools, you may mention them by specifying clearly which are free, which are commercial, and they need to be mainstream (not a way for marketing) with proper support and traction.

@jmanico
Copy link
Member

@jmanico jmanico commented Jun 7, 2020

@ThunderSon ThunderSon merged commit 6a80304 into OWASP:master Jun 18, 2020
2 of 3 checks passed
2 of 3 checks passed
link-check link-check
Details
lint
Details
Publishing Check
Details
@ThunderSon ThunderSon deleted the ThunderSon:feat/update-threatmodeling-cs branch Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants