Skip to content

/ CheatSheetSeries

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forgot Password CS Rewrite #410

Merged
merged 57 commits into from Jun 22, 2020
Merged

Forgot Password CS Rewrite #410

merged 57 commits into from Jun 22, 2020

Conversation

@ThunderSon
Copy link
Contributor

@ThunderSon ThunderSon commented Jun 6, 2020

This PR closes #159 and replaces #374

The forgot password CS focused heavily on the security questions.

In this rewrite, the CS focuses on:

  • multiple methods that could be used for the service
  • how to implement each method
  • common tasks to be conducted for all methods of forgot password
ThunderSon added 30 commits Dec 30, 2019
@ThunderSon
feat: introduction section
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 5D9DE82CA4F1029C Learn about signing commits
c71855b
@ThunderSon
feat: methods
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 5D9DE82CA4F1029C Learn about signing commits
115b842
@ThunderSon
feat: OTP method
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 5D9DE82CA4F1029C Learn about signing commits
3e0b36a
@ThunderSon
Merge branch 'master' into chore/forgot-password-rewrite
890127b
@ThunderSon
feat: the rest of the draft content
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 5D9DE82CA4F1029C Learn about signing commits
Loading status checks…
2f1fe68
@ThunderSon
chore: forgot MFA and grammar tweak
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
2085c24
@ThunderSon
feat: link to the MFA CS
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
44d53e1
@ThunderSon
chore: OTP - SMS note
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
0a7eed0
@ThunderSon
feat: url tokens secure practices
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
88677b2
@ThunderSon
chore: uniform italic using stars
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
6ec21d6
@ThunderSon
chore: sec questions note
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
c957300
@ThunderSon
chore: change pin to backup
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
b988d81
@ThunderSon
feat: backup codes
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
97884b2
@ThunderSon
chore: add final notes
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
a96a336
@ThunderSon
chore: ol to ul
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
6e4c4ab
@ThunderSon
chore: ToC
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
1c9e35c
@ThunderSon
chore: WSTG and OCSS urls
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
bcb4ed1
@ThunderSon
Merge branch 'master' into chore/forgot-password-rewrite
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
343e5f5
@ThunderSon
chore: operational security
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
329dc27
@ThunderSon
Merge branch 'chore/forgot-password-rewrite' of github.com:ThunderSon…
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
Loading status checks…
faedb35 
…/CheatSheetSeries into chore/forgot-password-rewrite
@ThunderSon
chore: MFA broken link ".md"
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
Loading status checks…
07bb22d
@ThunderSon
chore: basic comments
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
8f42c91
@ThunderSon
chore: codes and tokens secure practices
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
8207a76
@ThunderSon
chore: rm reset MFA and update URL tokens-codes
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
68e93b2
@ThunderSon
feat: forgot password service
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
Loading status checks…
01c07c9
@ThunderSon
feat: cross domain referer leakage
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
3591840
@ThunderSon
chore: ToC
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
Loading status checks…
741ec03
@ThunderSon
chore: more comments
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
Loading status checks…
20b8fca
@ThunderSon
chore: password request comments
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 5D9DE82CA4F1029C Learn about signing commits
30d1754
@ThunderSon
chore: token activation reword
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 5D9DE82CA4F1029C Learn about signing commits
9153188
@ThunderSon ThunderSon self-assigned this Jun 6, 2020
@ThunderSon
Copy link
Contributor Author

@ThunderSon ThunderSon commented Jun 6, 2020

@rbsec Ready for review. Once content is accepted, I will work on the note-look from MkDocs, and some grammar improvements here and there.
@rbsec
rbsec suggested changes Jun 7, 2020
View changes
Copy link
Contributor

@rbsec rbsec left a comment

I've made a few comments - would be good to chat about some of them on Slack at some point.
cheatsheets/Forgot_Password_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Forgot_Password_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Forgot_Password_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Forgot_Password_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/Forgot_Password_Cheat_Sheet.md Show resolved Hide resolved
cheatsheets/Forgot_Password_Cheat_Sheet.md Outdated Show resolved Hide resolved
ThunderSon added 3 commits Jun 7, 2020
@ThunderSon
chore: structure
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
3d4c9d4
@ThunderSon
chore: service patch up
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
e781a6a
@ThunderSon
chore: url token's 2 flows
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
Loading status checks…
22dce48
@ThunderSon
Copy link
Contributor Author

@ThunderSon ThunderSon commented Jun 16, 2020

Will finish this tomorrow. Having some thoughts about the MFA section.
ThunderSon added 5 commits Jun 20, 2020
@ThunderSon
chore: rm MFA and add Offline Methods
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
d299b78
@ThunderSon
chore: rm crypto CS
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
a9ae0b6
@ThunderSon
chore: update links
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
3a1b29e
@ThunderSon
feat: offline MFA process
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
09fa715
@ThunderSon
chore: offline methods description
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
Loading status checks…
962a48d
@ThunderSon ThunderSon requested a review from rbsec Jun 20, 2020
ThunderSon and others added 6 commits Jun 21, 2020
@ThunderSon
chore: url tokens and PINs
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
Loading status checks…
c8cc126
@ThunderSon
chore: offline methods MFA topics
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
Loading status checks…
8c982fb
@ThunderSon
chore: general grammar and sentence touches
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
Loading status checks…
8e7b84a
@rbsec
Various wording change
Loading status checks…
e04e7b8
@rbsec
Clarify why not to automatically log the user in.
Loading status checks…
46ae05c
@rbsec
Add link to resetting MFA
Loading status checks…
42d9fd4
@rbsec
rbsec reviewed Jun 21, 2020
View changes
cheatsheets/Forgot_Password_Cheat_Sheet.md Outdated Show resolved Hide resolved
rbsec and others added 3 commits Jun 21, 2020
@rbsec
Typo fix
Loading status checks…
84a0bec
@rbsec
Improve section intro
Loading status checks…
daa29ec
@ThunderSon
chore: md lint fixes
Verified
This commit was signed with a verified signature.
ThunderSon
GPG key ID: 523F5CE2014AA7D3 Learn about signing commits
Loading status checks…
93ef208
@rbsec
rbsec reviewed Jun 21, 2020
View changes
Copy link
Contributor

@rbsec rbsec left a comment

Looks good, happy for this to be merged.
@rbsec
Fix link
Loading status checks…
06bfc88
@rbsec rbsec dismissed their stale review via 06bfc88 Jun 21, 2020
@rbsec
rbsec approved these changes Jun 21, 2020
View changes
@ThunderSon ThunderSon merged commit 44328a5 into OWASP:master Jun 22, 2020
3 checks passed
3 checks passed
link-check
Details
lint
Details
Publishing Check
Details
@ThunderSon ThunderSon deleted the ThunderSon:forgot-password-rewrite branch Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbsec rbsec

@mackowski mackowski

Assignees

@ThunderSon ThunderSon

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Cheat sheet update/refactor proposal: Forgot Password Cheat Sheet
2 participants
@ThunderSon @rbsec