README Rewrite #433
Merged
README Rewrite #433
Conversation
Verified
This commit was signed with a verified signature.
Verified
This commit was signed with a verified signature.
Verified
This commit was signed with a verified signature.
Verified
This commit was signed with a verified signature.
Verified
This commit was signed with a verified signature.
Verified
This commit was signed with a verified signature.
Verified
This commit was signed with a verified signature.
|
I will not merge it for now to let @rbsec to review. |
|
@ThunderSon I made some changes to what you'd done - mostly minor wording and style ones. The contribution guide changes got a bit bigger - we had two different sections about Markdown styling which I combined. |
|
A small touch on the contributing guide |
|
Should we handle the preface in here? I feel like removing that file and just replacing it with the README on the main website. |
|
+1 agree
…--
Jim Manico
@manicode
On Jun 24, 2020, at 2:45 PM, ThunderSon ***@***.***> wrote:
Should we handle the preface in here? I feel like removing that file and just replacing it with the README on the main website.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Verified
This commit was signed with a verified signature.
…CheatSheetSeries into chore/readme-rewrite
Verified
This commit was signed with a verified signature.
|
After giving it a second thought, the preface needs to stay separate as the content that should be shown on the website needs to differ a bit from the README (which focuses more on GitHub). I'll give it another look later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Another PR will be created to remove the preface (we don't need that) and update the showcased page on the website, as well as updating the contributing guide.