Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #437

Merged
merged 4 commits into from Jul 17, 2020
Merged

Fix typo #437

merged 4 commits into from Jul 17, 2020

Conversation

@cmcconomy
Copy link
Contributor

@cmcconomy cmcconomy commented Jul 2, 2020

Offsensives -> Offensives

Fix typo
Offsensives -> Offensives
@cmcconomy cmcconomy requested review from mackowski, rbsec and ThunderSon as code owners Jul 2, 2020
@cmcconomy
Copy link
Contributor Author

@cmcconomy cmcconomy commented Jul 2, 2020

Failure is due to 503 returned from abuseipdb; seems silly to have a pull request fail because one of the sites is having a maintenance issue:

AbuseIPDB
Is Down For Maintenance
We apologize for any inconvenience.
We are making changes to our site to improve your experience.

Please check back at a later time.

@ThunderSon
Copy link
Contributor

@ThunderSon ThunderSon commented Jul 2, 2020

No worries, the links if not related to the PR at hand are not blockers :)

@@ -101,7 +101,7 @@ Make a workshop that includes people with the following profiles:

- **Business analyst**: Will be the business key people that will describe each feature from a business point of view.
- **Risk analyst**: Will be the company's risk personnel that will evaluate the business risk from a proposed attack (sometimes it is the **Business analyst** depending on the company).
- **Offsensives (Pentester or Application Security people with offensive mindset)**: Will be the *attacker* that will propose all attacks that he can perform on the business feature(s) in question. If the company does not have a person with this profile then it is possible to request the service of an external specialist (Pentester or AppSec consultant from a security firm). If possible, include 2 offensives people (ex: 1 Pentester + 1 AppSec) in order to increase the number of possible attacks that will be identified and considered.
- **Offensives (Pentester or Application Security people with offensive mindset)**: Will be the *attacker* that will propose all attacks that he can perform on the business feature(s) in question. If the company does not have a person with this profile then it is possible to request the service of an external specialist (Pentester or AppSec consultant from a security firm). If possible, include 2 offensives people (ex: 1 Pentester + 1 AppSec) in order to increase the number of possible attacks that will be identified and considered.

This comment has been minimized.

@ThunderSon

ThunderSon Jul 2, 2020
Contributor

What do you think about this?

Suggested change
- **Offensives (Pentester or Application Security people with offensive mindset)**: Will be the *attacker* that will propose all attacks that he can perform on the business feature(s) in question. If the company does not have a person with this profile then it is possible to request the service of an external specialist (Pentester or AppSec consultant from a security firm). If possible, include 2 offensives people (ex: 1 Pentester + 1 AppSec) in order to increase the number of possible attacks that will be identified and considered.
- **Security officer**: Will be the *attacker* that will propose attacks that they can perform on the business feature(s) in question. If the company does not have a person with this profile then it is possible to request the service of an external specialist. If possible, include 2 security officers with different backgrounds in order to increase the number of possible attacks that will be identified and considered.

This comment has been minimized.

@cmcconomy

cmcconomy Jul 6, 2020
Author Contributor

I think it's an improvement.
Officer? Engineer?

This comment has been minimized.

@rbsec

rbsec Jul 6, 2020
Contributor

If you're talking about an attacker, then "penetration tester" or "red team" would make more sense to me.

"security officer" is a bit vague - I don't really know what to expect from someone in that role, but I would think it's more on the defensive and governance side.

This comment has been minimized.

@cmcconomy

cmcconomy Jul 6, 2020
Author Contributor

Good point - the role here is really limited to Attacker. Whether an organization's "Security Officer" fulfills this role as part of a broader mandate is outside the scope of this recommended approach, where targeted/specific roles are required to accomplish the activities.

This role must be capable of brainstorming potential feasible attacks on the application.

This comment has been minimized.

@ThunderSon

ThunderSon Jul 6, 2020
Contributor

Please go forward with using "Penetration Tester"

This comment has been minimized.

@cmcconomy

cmcconomy Jul 10, 2020
Author Contributor

Sorry to be a bother; I submitted this change directly via the github web ui - I'm unfamilar with how to revise the merge request. Could you let me know how best to revise my change? Should I cancel and resubmit or is there a way to add a subsequent revision directly on the site without checking out the repo?

This comment has been minimized.

@mackowski

mackowski Jul 10, 2020
Collaborator

You can go to the „Files changed” in this PR, click on three dots in the upper right corner and choose edit file.

This comment has been minimized.

@cmcconomy

cmcconomy Jul 10, 2020
Author Contributor

Thank you; second set of changes submitted.

Updated term "Offensive" / "Offsensive"[sic] with Penetration Tester as per conversation.
Copy link
Contributor

@ThunderSon ThunderSon left a comment

no need to have penetration testers in capital, they can be used in a similar fashion to this sentence. Only bold words need to be capitalized.

@@ -101,7 +101,7 @@ Make a workshop that includes people with the following profiles:

- **Business analyst**: Will be the business key people that will describe each feature from a business point of view.
- **Risk analyst**: Will be the company's risk personnel that will evaluate the business risk from a proposed attack (sometimes it is the **Business analyst** depending on the company).
- **Offsensives (Pentester or Application Security people with offensive mindset)**: Will be the *attacker* that will propose all attacks that he can perform on the business feature(s) in question. If the company does not have a person with this profile then it is possible to request the service of an external specialist (Pentester or AppSec consultant from a security firm). If possible, include 2 offensives people (ex: 1 Pentester + 1 AppSec) in order to increase the number of possible attacks that will be identified and considered.
- **Penetration Tester**: Will be the *attacker* that will propose all attacks that he can perform on the business feature(s) in question. If the company does not have a person with this profile then it is possible to request the service of an external specialist (Pentester or AppSec consultant from a security firm). If possible, include 2 Penetration Testers from diverse backgrounds in order to increase the number of possible attacks that will be identified and considered.

This comment has been minimized.

@ThunderSon

ThunderSon Jul 14, 2020
Contributor

Suggested change
- **Penetration Tester**: Will be the *attacker* that will propose all attacks that he can perform on the business feature(s) in question. If the company does not have a person with this profile then it is possible to request the service of an external specialist (Pentester or AppSec consultant from a security firm). If possible, include 2 Penetration Testers from diverse backgrounds in order to increase the number of possible attacks that will be identified and considered.
- **Penetration Tester**: Will be the *attacker* that will propose attacks that they can perform on the business feature(s) in question. If the company does not have a person with this profile then it is possible to request the service of an external specialist. If possible, include 2 penetration testers with different backgrounds in order to increase the number of possible attacks that will be identified and considered.
cheatsheets/Abuse_Case_Cheat_Sheet.md Show resolved Hide resolved
cmcconomy added 2 commits Jul 14, 2020
Made proposed changed with the exception of stating that a penetration tester is responsible for defining the countermeasure / protection against the attack
Made proposed changed with the exception of stating that a penetration tester is responsible for defining the countermeasure / protection against the attack
@ThunderSon
Copy link
Contributor

@ThunderSon ThunderSon commented Jul 17, 2020

Thanks @cmcconomy !

@ThunderSon ThunderSon merged commit 2ea33da into OWASP:master Jul 17, 2020
3 checks passed
3 checks passed
link-check
Details
lint
Details
Publishing Check
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants