Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos plus markdown in CSRF cheatsheet #463

Merged
merged 2 commits into from Aug 6, 2020
Merged

Fix typos plus markdown in CSRF cheatsheet #463

merged 2 commits into from Aug 6, 2020

Conversation

@mohawk2
Copy link
Contributor

@mohawk2 mohawk2 commented Aug 5, 2020

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Done.

This PR is motivated by https://cheatsheetseries.owasp.org/cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.html having a \ after "Generate the token", which is obviously unintended, and appears to be caused by GFM making it look as intended, but not your Markdown -> HTML converter.

By the way, your PR template links to https://github.com/OWASP/CheatSheetSeries#conversion-rules but that does not seem to exist now.

Thank you again for your contribution 😃

I hope it's useful!

mohawk2 added 2 commits Aug 5, 2020
@mohawk2 mohawk2 requested review from jmanico and mackowski as code owners Aug 5, 2020
@jmanico
jmanico approved these changes Aug 5, 2020
Copy link
Member

@jmanico jmanico left a comment

Great PR thanks for the cleanup!

@mohawk2
Copy link
Contributor Author

@mohawk2 mohawk2 commented Aug 5, 2020

That was quick!

Copy link
Collaborator

@mackowski mackowski left a comment

LGTM

@mackowski mackowski merged commit bd88852 into OWASP:master Aug 6, 2020
3 checks passed
3 checks passed
link-check
Details
lint
Details
Publishing Check
Details
@mohawk2 mohawk2 deleted the mohawk2:patch-1 branch Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants