Update Authorization CS draft #478
Merged
Conversation
- added content to Deny by Default and Least Privileges sections - update header on tool/framework/technology usage
|
@KellyMarchewa so far it looks awesome for me. |
|
Thanks for the feedback @mackowski . To my understanding, this CS was supposed to be replacement/merging for both the current IDOR and Access Control CSs. Regarding the concepts covered in those sheets:
Hope I covered everything. Looking forward to getting more work done on this soon. |
|
I support this work, bigtime! It’s a needed change.
…--
Jim Manico
@manicode
Secure Coding Education
+1 (808) 652-3805
On Sep 10, 2020, at 1:35 PM, Kelly Marchewa ***@***.***> wrote:
Thanks for the feedback @mackowski . To my understanding, this CS was supposed to be replacement/merging for both the current IDOR and Access Control CSs. Regarding the concepts covered in those sheets:
Per an earlier discussion, it seemed to have been agreed in-depth discussions of MAC and DAC were not necessarily relevant for the scope of the CS. RBAC will necessarily be discussed under the "Prefer Feature and Attribute Based Access Control over RBAC" section.
Currently, I did not have plans to formally and explicitly explore the concept of permissions, but would be glad to do so if wanted.
Far as IDOR, I think the discussion under the header "Ensure Lookup IDs are Not Accessible Even When Guessed or Cannot Be Tampered With" will perhaps most closely relate to the current IDOR CS, though other sections (such as "Validate the Permissions on Every Request") will probably also be relevant.
Hope I covered everything. Looking forward to getting more work done on this soon.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Well done, I am sorry this took me 16 days to approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR covers issue #474
Updated one of the headers slightly per feedback in the linked issue.
Thanks and looking forward to any discussions/feedback for improvement.