Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker_Security_Cheat_Sheet.md #505

Merged
merged 2 commits into from Nov 9, 2020
Merged

Conversation

@gbrindisi
Copy link
Contributor

@gbrindisi gbrindisi commented Oct 18, 2020

Adding a reference for Dockerfile best practices.

This PR covers issue #504

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as TEXT
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR covers issue #.

Thank you again for your contribution 😃

Adding a reference for Dockerfile best practices
@gbrindisi gbrindisi requested review from jmanico and mackowski as code owners Oct 18, 2020
Copy link
Collaborator

@mackowski mackowski left a comment

Hey thanks for this PR. In addition to the link please find the practices that are missing or should be updated in the cheatsheet and add them to it to make the recommendations better.

@gbrindisi
Copy link
Contributor Author

@gbrindisi gbrindisi commented Nov 6, 2020

@mackowski hey there! I've added a new rule to address Dockerfile linting

Copy link
Collaborator

@mackowski mackowski left a comment

Awesome, thank you!

@mackowski mackowski merged commit 5e3385b into OWASP:master Nov 9, 2020
2 of 3 checks passed
2 of 3 checks passed
lint lint
Details
link-check
Details
Publishing Check
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants