Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major reworking of the pepper section #526

Merged
merged 1 commit into from Jan 15, 2021

Conversation

@chrisdlangton
Copy link
Contributor

@chrisdlangton chrisdlangton commented Jan 11, 2021

This will remove all mentions of storing a pepper (application secret) in a config file.
The alternatives described in the Disadvantages section were covering the same ground, so i reworked these to be in their own Alternatives section with more context on how they differ from the common pepper method.
Also removed references to ambiguous and irrelevant words like traditional and use more appropriate terms that demonstrate a clear message.
Also introduces the concept of CSPRNG to pepper generation, which is critical for security of session which share the similar characteristics to a pepper.
Updated the concatenation to a prefix approach which mitigates known attacks against peppering and avoid some implementation bugs such as truncation.

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as TEXT
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR covers issue #.

Thank you again for your contribution 😃

This will remove all mentions of storing a pepper (application secret) in a config file.
The *alternatives* described in the *Disadvantages* section were covering the same ground, so i reworked these to be in their own *Alternatives* section with more context on how they differ from the common pepper method.
Also removed references to ambiguous and irrelevant words like *traditional* and use more appropriate terms that demonstrate a clear message.
Also introduces the concept of CSPRNG to pepper generation, which is critical for security of session which share the similar characteristics to a pepper.
Updated the concatenation to a prefix approach which mitigates known attacks against peppering and avoid some implementation bugs such as truncation.
@chrisdlangton chrisdlangton requested review from jmanico and mackowski as code owners Jan 11, 2021
Copy link
Member

@jmanico jmanico left a comment

omg this is so fabulous and my only regret is not reviewing this sooner

@jmanico jmanico merged commit 0c719d5 into OWASP:master Jan 15, 2021
3 checks passed
3 checks passed
link-check
Details
lint
Details
Publishing Check
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants