Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Security Policy Cheat Sheet with more info #528

Merged
merged 4 commits into from Jan 27, 2021
Merged

Conversation

@shaialon
Copy link
Contributor

@shaialon shaialon commented Jan 23, 2021

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as TEXT
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR covers issue #.

Thank you again for your contribution 😃

@shaialon shaialon requested review from jmanico and mackowski as code owners Jan 23, 2021
Copy link
Member

@jmanico jmanico left a comment

Can you just link up caniuse for navigate-to and clarify the use of the term unsigned?

@jmanico

This comment has been minimized.

Copy link
Member

@jmanico jmanico commented on a8e999b Jan 23, 2021

Looks good

@jmanico

This comment has been minimized.

Copy link
Member

@jmanico jmanico commented on 849f7b9 Jan 23, 2021

great

Updated based on @jmanico 's advice.
@shaialon shaialon requested a review from jmanico Jan 25, 2021
Copy link
Collaborator

@mackowski mackowski left a comment

Looks good! Thank you!

@shaialon
Copy link
Contributor Author

@shaialon shaialon commented Jan 27, 2021

@jmanico , are we good to merge?
(it seems to be stuck pending your approval...)
Thanks.
image

Copy link
Member

@jmanico jmanico left a comment

Great work!

@jmanico jmanico merged commit 4f72ca1 into OWASP:master Jan 27, 2021
3 checks passed
3 checks passed
link-check
Details
lint
Details
Publishing Check
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants