Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Laravel Cheat Sheet #531

Merged
merged 3 commits into from Feb 3, 2021
Merged

New Laravel Cheat Sheet #531

merged 3 commits into from Feb 3, 2021

Conversation

@paras-malhotra
Copy link
Contributor

@paras-malhotra paras-malhotra commented Jan 29, 2021

Checklist:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as TEXT
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

Closes #527.

I'm leaving this open until next week to invite feedback from the Laravel community. I'll tweet about this and get some reviews going!

In the meantime, feel free to provide feedback on this. This is my first CS. I've tried to cover as much as possible and based the structure off the Ruby on Rails CS.

@jmanico

This comment has been minimized.

Copy link
Member

@jmanico jmanico commented on 6f107da Jan 29, 2021

Looks good but I see the error message:

This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

@jmanico

This comment has been minimized.

Copy link
Member

@jmanico jmanico commented on affe370 Jan 29, 2021

Looks good but I see the error message:

This commit does not belong to any branch on this repository and may belong to a fork outside of the repository.

@paras-malhotra
Copy link
Contributor Author

@paras-malhotra paras-malhotra commented Jan 30, 2021

@jmanico, the commits will be pulled in once this PR is merged. I think the issue may be that I added this to the master branch of my fork instead of creating a separate branch.

@paras-malhotra
Copy link
Contributor Author

@paras-malhotra paras-malhotra commented Feb 3, 2021

@jmanico, I've consulted some Laravel folks and this looks good to go! Let me know if you'd like me to make any changes.

Copy link
Member

@jmanico jmanico left a comment

What a huge and solid effort. The changes I'd like to suggest are not blocking so I'll approve and merge

@jmanico jmanico merged commit 485d8fa into OWASP:master Feb 3, 2021
3 checks passed
3 checks passed
link-check
Details
lint
Details
Publishing Check
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants