fix: always show all CRE links on CRE pages without collapsing (#901)#909
Open
shreeshtripurwarcomp23-coder wants to merge 1 commit into
Open
Conversation
Collaborator
|
@shreeshtripurwarcomp23-coder Add the screenshot/screen recording of the result |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #901
Problem
On a CRE page, lists of linked CREs were being collapsed after 5 items,
requiring users to click "Show more" to see the rest. This happened because
the collapse logic in CommonRequirementEnumeration.tsx did not distinguish
between CRE links and links to external standards.
Fix
Added a check in CommonRequirementEnumeration.tsx: if all links in a group
are CREs, show all of them without collapsing and hide the "Show more" button.
Links to external standards still collapse as before.
This matches the logic already present in DocumentNode.tsx (allLinksAreCres).
Changes
application/frontend/src/pages/CommonRequirementEnumeration/CommonRequirementEnumeration.tsxDOCUMENT_TYPESfrom../../constallLinksAreCresbefore rendering each link groupvisibleResults(full list when CREs, sliced otherwise) instead of inline slice!allLinksAreCres