From 5b10571734d8cb16eb9e2380ce3c69e96f059798 Mon Sep 17 00:00:00 2001 From: Shreesh Tripurwar Date: Sun, 24 May 2026 11:43:07 +0530 Subject: [PATCH] fix: always show all CRE links on CRE pages without collapsing (#901) --- .../CommonRequirementEnumeration.tsx | 32 +++++++++++-------- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/application/frontend/src/pages/CommonRequirementEnumeration/CommonRequirementEnumeration.tsx b/application/frontend/src/pages/CommonRequirementEnumeration/CommonRequirementEnumeration.tsx index d51255c5b..c3d4a98f9 100644 --- a/application/frontend/src/pages/CommonRequirementEnumeration/CommonRequirementEnumeration.tsx +++ b/application/frontend/src/pages/CommonRequirementEnumeration/CommonRequirementEnumeration.tsx @@ -8,6 +8,7 @@ import { Icon } from 'semantic-ui-react'; import { DocumentNode } from '../../components/DocumentNode'; import { ClearFilterButton, FilterButton } from '../../components/FilterButton/FilterButton'; import { LoadingAndErrorIndicator } from '../../components/LoadingAndErrorIndicator'; +import { DOCUMENT_TYPES } from '../../const'; import { useEnvironment } from '../../hooks'; import { applyFilters, filterContext } from '../../hooks/applyFilters'; import { Document } from '../../types'; @@ -106,25 +107,30 @@ export const CommonRequirementEnumeration = () => { const sortedResults = links.sort((a, b) => getDocumentDisplayName(a.document).localeCompare(getDocumentDisplayName(b.document)) ); + const allLinksAreCres = + sortedResults.length > 0 && + sortedResults.every((link) => link.document.doctype === DOCUMENT_TYPES.TYPE_CRE); + const visibleResults = + allLinksAreCres || showAll[type] + ? sortedResults + : sortedResults.slice(0, MAX_LENGTH_FOR_AUTO_EXPAND); return (
Which {getDocumentTypeText(type, links[0].document.doctype)}: {/* Risk of mixed doctype in here causing odd output */}
- {sortedResults - .slice(0, showAll[type] ? sortedResults.length : MAX_LENGTH_FOR_AUTO_EXPAND) - .map((link, i) => ( -
- - -
- ))} - {sortedResults.length > MAX_LENGTH_FOR_AUTO_EXPAND && ( + {visibleResults.map((link, i) => ( +
+ + +
+ ))} + {!allLinksAreCres && sortedResults.length > MAX_LENGTH_FOR_AUTO_EXPAND && (