Skip to content

fix: always show all CRE links on CRE pages without collapsing (#901) #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shreeshtripurwarcomp23-coder wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −13
Open

fix: always show all CRE links on CRE pages without collapsing (#901) #909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions application/frontend/src/pages/CommonRequirementEnumeration/CommonRequirementEnumeration.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { Icon } from 'semantic-ui-react';
import { DocumentNode } from '../../components/DocumentNode';
import { ClearFilterButton, FilterButton } from '../../components/FilterButton/FilterButton';
import { LoadingAndErrorIndicator } from '../../components/LoadingAndErrorIndicator';
import { DOCUMENT_TYPES } from '../../const';
import { useEnvironment } from '../../hooks';
import { applyFilters, filterContext } from '../../hooks/applyFilters';
import { Document } from '../../types';
Expand Down Expand Up @@ -106,25 +107,30 @@ export const CommonRequirementEnumeration = () => {
const sortedResults = links.sort((a, b) =>
getDocumentDisplayName(a.document).localeCompare(getDocumentDisplayName(b.document))
);
const allLinksAreCres =
sortedResults.length > 0 &&
sortedResults.every((link) => link.document.doctype === DOCUMENT_TYPES.TYPE_CRE);
const visibleResults =
allLinksAreCres || showAll[type]
? sortedResults
: sortedResults.slice(0, MAX_LENGTH_FOR_AUTO_EXPAND);
return (
<div className="cre-page__links" key={type}>
<div className="cre-page__links-eader">
<b>Which {getDocumentTypeText(type, links[0].document.doctype)}</b>:
{/* Risk of mixed doctype in here causing odd output */}
</div>
{sortedResults
.slice(0, showAll[type] ? sortedResults.length : MAX_LENGTH_FOR_AUTO_EXPAND)
.map((link, i) => (
<div
key={i}
className="accordion ui fluid styled cre-page__links-container"
style={{ marginBottom: '4px' }}
>
<DocumentNode node={link.document} linkType={type} />
<FilterButton document={link.document} />
</div>
))}
{sortedResults.length > MAX_LENGTH_FOR_AUTO_EXPAND && (
{visibleResults.map((link, i) => (
<div
key={i}
className="accordion ui fluid styled cre-page__links-container"
style={{ marginBottom: '4px' }}
>
<DocumentNode node={link.document} linkType={type} />
<FilterButton document={link.document} />
</div>
))}
{!allLinksAreCres && sortedResults.length > MAX_LENGTH_FOR_AUTO_EXPAND && (
<button
onClick={() => setShowAll((prev) => ({ ...prev, [type]: !prev[type] }))}
style={{ marginTop: '8px', cursor: 'pointer' }}
Expand Down