Add deep-chain-no-fix regression fixture (#528)#558
Merged
Conversation
Complements wrong-parent: express → body-parser → qs@6.14.2 where body-parser@1.20.4 declares ~6.14.0 (does not cover 6.15.2+). CVE Lite should suggest npm install express@4.22.2, not npm update qs.
Contributor
Author
|
cc: @sonukapoor |
sonukapoor
approved these changes
Jun 7, 2026
sonukapoor
left a comment
sonukapoor
left a comment
Collaborator
There was a problem hiding this comment.
Tested - correctly emits npm install express@4.22.2 (parent upgrade, not lockfile refresh) for the deep chain where the parent range doesn't cover the fix. Good complement to wrong-parent.
Collaborator
|
Merged — thank you @Ayush7614! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/deep-chain-no-fix/for Discussion Help wanted: edge case lockfile fixtures for regression testing #528 fixture 1examples/wrong-parent/: 3-level chain where the intermediate parent range does not cover the OSV fixexpress@4.22.1→body-parser@1.20.4→qs@6.14.2(npm overrides isolate the deep path and pin vulnerable versions)body-parserdeclaresqs: ~6.14.0— does not permit6.15.2+examples/readme.md(also addswrong-parentto the table)Verified scan output
package-lock.jsonqs@6.14.2(transitive viaexpress → body-parser → qs)npm install express@4.22.2(parent upgrade)npm update qsTest plan
node dist/index.js examples/deep-chain-no-fix --verbose→ parent upgrade onexpress, not lockfile refresh onqsCloses Discussion #528 item fixture 1 (regression fixture).