Add pnpm-aliased-chain regression fixture (#528)#559
Conversation
|
cc: @sonukapoor |
sonukapoor
left a comment
sonukapoor
left a comment
There was a problem hiding this comment.
Tested - correctly resolves the aliased pnpm v9 chain and emits pnpm add vercel@32.0.2 with the full dependency path through the alias. Good regression fixture for the v1.18.2 pnpm alias fix.
|
The fixture and scan output look correct - |
Minimal pnpm v9 lockfile reproducing the formisch/vm2 alias bug: deep transitive vm2@3.9.19 through @remix-run/dev → @vercel/remix-run-dev. Path resolution must keep the real package name and suggest pnpm add vercel.
|
Rebased against |
sonukapoor
left a comment
sonukapoor
left a comment
There was a problem hiding this comment.
CI passing, fixture verified earlier - correctly emits pnpm add vercel@32.0.2 for the aliased vm2 chain. Good regression fixture for the v1.18.2 pnpm alias fix.
|
Merged — thank you @Ayush7614! |
2 participants
Summary
examples/pnpm-aliased-chain/for Discussion Help wanted: edge case lockfile fixtures for regression testing #528 fixture 6vercel→@vercel/remix-builder→@remix-run/dev(alias →@vercel/remix-run-dev) →vm2@3.9.19'@remix-run/dev': '@vercel/remix-run-dev@1.16.1'— dep name differs from real package nameexamples/readme.mdVerified scan output
pnpm-lock.yamlvm2@3.9.19(transitive)project → vercel → @vercel/remix-builder → @vercel/remix-run-dev → vm2(real name, not alias)pnpm add vercel@32.0.2(parent upgrade — not a broken direct-install on the alias name)Test plan
node dist/index.js examples/pnpm-aliased-chain --verbose→ correct 5-hop path through aliased intermediatetests/parsers.test.ts— "resolves transitive paths through pnpm v9 aliased dependencies"Closes Discussion #528 fixture 6 (regression fixture).