Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple CryptoKit #1478

Merged
merged 3 commits into from Oct 5, 2019

Conversation

@cak
Copy link
Collaborator

commented Oct 1, 2019

Add Apple CryptoKit

Thank you for submitting a Pull Request to the Mobile Security Testing Guide. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR covers issue #1317 and #961.

Issues #1317 and #961
@commjoen commjoen requested review from commjoen and DarkInnocence Oct 1, 2019
@commjoen

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

@DarkInnocence can you review this pr please :)?

Copy link
Collaborator

left a comment

Thanks a lot for your contribution, this is very much appreciated! :)

I have just two minor remarks and then we're good to go for me 👍

Document/0x06e-Testing-Cryptography.md Outdated Show resolved Hide resolved
Document/0x06e-Testing-Cryptography.md Outdated Show resolved Hide resolved
cak and others added 2 commits Oct 2, 2019
Co-Authored-By: Jeroen Beckers <info@dauntless.be>
@cak cak requested a review from TheDauntless Oct 3, 2019
@commjoen commjoen requested review from TheDauntless and removed request for DarkInnocence and TheDauntless Oct 5, 2019
@commjoen commjoen merged commit c82fb1d into OWASP:master Oct 5, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@commjoen commjoen referenced this pull request Oct 8, 2019
17 of 17 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.