-
-
Notifications
You must be signed in to change notification settings - Fork 229
Fix typo in README.md about reporting guidelines #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
I'm not sure how we could have made it more obvious you were doing the wrong thing. It's all over the PR template and the comment bot also reminded you. |
|
Maybe add a link or hint to those instructions instead of just a link on
the published page that says "Edit on GitHub
<https://github.com/OWASP/www-project-web-security-testing-guide/blob/master/stable/4-Web_Application_Security_Testing/10-Business_Logic_Testing/02-Test_Ability_to_Forge_Requests.md>"
? which just takes me straight to the master (which you should really call
'main') branch on the repo in context?
…On Fri, Nov 7, 2025 at 10:03 AM Rick M ***@***.***> wrote:
Closed #470
<#470>
.
—
Reply to this email directly, view it on GitHub
<#470 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BWHQPL5H24F7JPR4KHTY4IL33TNGNAVCNFSM6AAAAACLOY52VKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQG44TGOBYGQ4TQMY>
.
You are receiving this because you authored the thread.Message ID:
<OWASP/www-project-web-security-testing-guide/pull/470/issue_event/20793884983
@github.com>
|
|
You might also want to change your communication style moving fwd e.g.
"thanks for your contribution and support, however please next time follow
the guidelines for contributing..." instead of the tone you took - thanks
On Fri, Nov 7, 2025 at 10:07 AM Garrey Learmonth ***@***.***>
wrote:
… Maybe add a link or hint to those instructions instead of just a link on
the published page that says "Edit on GitHub
<https://github.com/OWASP/www-project-web-security-testing-guide/blob/master/stable/4-Web_Application_Security_Testing/10-Business_Logic_Testing/02-Test_Ability_to_Forge_Requests.md>"
? which just takes me straight to the master (which you should really
call 'main') branch on the repo in context?
On Fri, Nov 7, 2025 at 10:03 AM Rick M ***@***.***> wrote:
> Closed #470
> <#470>
> .
>
> —
> Reply to this email directly, view it on GitHub
> <#470 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BWHQPL5H24F7JPR4KHTY4IL33TNGNAVCNFSM6AAAAACLOY52VKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQG44TGOBYGQ4TQMY>
> .
> You are receiving this because you authored the thread.Message ID:
> <OWASP/www-project-web-security-testing-guide/pull/470/issue_event/20793884983
> @github.com>
>
|
Fair, sadly the edit on GitHub link is controlled by the OWASP.org theme and we can’t suppress it. |
Garrey, point taken. My frustration shouldn’t have been directed at you. We’ll look at how we can clarify further. The typo issues has been fixed upstream. |
|
many thanks
…On Fri, Nov 7, 2025 at 11:58 AM Rick M ***@***.***> wrote:
*kingthorin* left a comment
(OWASP/www-project-web-security-testing-guide#470)
<#470 (comment)>
You might also want to change your communication style moving fwd e.g.
"thanks for your contribution and support, however please next time follow
the guidelines for contributing..." instead of the tone you took - thanks
On Fri, Nov 7, 2025 at 10:07 AM Garrey Learmonth *@*.***>
Garrey, point taken. My frustration shouldn’t have been directed at you.
We’ll look at how we can clarify further.
The typo issues has been fixed upstream.
—
Reply to this email directly, view it on GitHub
<#470 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BWHQPL6JGNEHU2ZUVMBMIR333T2W5AVCNFSM6AAAAACLOY52VKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKMBUGYZTQOJVGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
Content PRs should generally be made against the the project repo: "OWASP/wstg" - https://github.com/OWASP/wstg
Caution
Contributions should only be made in the proper repo against the latest content. Please don't open PRs here for versioned or stable content, they represent point-in-time state.