Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
"Smarty Price formater" in basket, article details and article lists.… #129
… This was already introduced in v4.8.0, but forgotten in several places in Flow ( https://oxidforge.org/en/oxid-eshop-version-4-8-0-ce-pe-5-1-0-ee.html#Simply_switch_the_position_of_the_currency_sign ).
Hello @Josef-A-Puckl, thanks for the pull request! The places you have tried to fix, are not so easy to fix: Please take a look how those methods like getFTPrice work - it prepares corresponding netto/brutto price on shop configurations :(, so for now, there is no simple solution, and yours is not right, as this logic will be skipped at all. I have reverted those templates, for now, please make a new the pull request if you have ideas how to improve it.
Regarding priceinfo.tpl, fbrutprice and fbrutamountprice are already formatted.. yes, it is bad, but need to fix it first, only after fixing we could apply the oxprice formatting on the top. What can you do:
Please try to make smaller pull requests, ideally - one little problem - one pull request, so we could check and take it faster. Here we have 3 or 4 places with quite different logic, even if it looks related and similar.
With the reverts I have mentioned, I have merged improvements from the Pull request (25e437a)!
If something I have found is wrong, please tell me, maybe I have misunderstood something.. I am human! :)