Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6886: exclude non-essential files from dist package #136

Closed

Conversation

Projects
None yet
4 participants
@kaluzki
Copy link
Contributor

commented Nov 29, 2018

@CLAassistant

This comment has been minimized.

Copy link

commented Nov 29, 2018

CLA assistant check
All committers have signed the CLA.

@Sieg

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2018

Merged at 0dc1252

@Sieg Sieg closed this Dec 3, 2018

@Sieg Sieg self-assigned this Dec 3, 2018

@Sieg Sieg added the Ready to merge label Dec 3, 2018

@ivoba

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

@Sieg this breaks extending the flow theme with child themes when importing less files from the parent theme in the child theme.
Also reusing javascripts from parent theme will not work anymore.

If this is done by purpose how should child-themes be set-up now?

@kaluzki

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2019

@Sieg this breaks extending the flow theme with child themes when importing less files from the parent theme in the child theme.
Also reusing javascripts from parent theme will not work anymore.

If this is done by purpose how should child-themes be set-up now?

composer update|install --prefer-source

for more details see https://stackoverflow.com/a/46641804/3263617

@ivoba

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

@kaluzki yes thx this would bring the build folder to vendor dir.

However overriding styles in the child theme would mean a lot of path changing in scss files or copying the build folder manually to the child theme. (Since the grunt task would need to be copied anyway)

Then i would rather fork wave theme and use the fork as main theme, no child themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.