Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart counter in <span class="badge"> #138

Closed

Conversation

Projects
None yet
4 participants
@internetfabrik
Copy link

commented Dec 2, 2018

I wrapped the product counter of the cart buttons (minibasket.tpl and menubasket.tpl) in a span tag with the class of "badge", so it can be styled with CSS. This way, the cart counter is now analogous to the counter of the servicemenu button.

Additionally, I removed a command from theme.less (and thus styles.min.css) that set the padding of the cart button to zero. Maybe this was a relic of the old SVG icon version, but with the current icon, it created an uneven spacing between the buttons, and it made the hit area of the cart button somewhat small.

@CLAassistant

This comment has been minimized.

Copy link

commented Dec 2, 2018

CLA assistant check
All committers have signed the CLA.

@internetfabrik internetfabrik changed the title Warenkorb-Zähler in <span class="badge">; padding um Warenkorb-Button… Cart counter in <span class="badge"> Dec 2, 2018

@Sieg

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2018

New:
image

Old:
image

@Sieg Sieg self-assigned this Dec 3, 2018

@tarique-iqbal tarique-iqbal force-pushed the OXID-eSales:master branch from 2accedf to 996d039 Jan 25, 2019

@Sieg

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

Hello @internetfabrik, merged your improvement to master.

@Sieg Sieg closed this Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.