Permalink
Browse files

Merge pull request #480 from TeamPull/patch-34

Remove questenmark from external link
  • Loading branch information...
2 parents dc06562 + 17750fa commit 2107529aeed34647de0896ec80db25915bb4f7bb @ambrosiustopor ambrosiustopor committed on GitHub Feb 14, 2017
Showing with 4 additions and 4 deletions.
  1. +1 −1 source/Application/Model/Category.php
  2. +3 −3 tests/Unit/Application/Model/CategoryTest.php
@@ -641,7 +641,7 @@ public function getBaseStdLink($iLang, $blAddId = true, $blFull = true)
public function getStdLink($iLang = null, $aParams = array())
{
if (isset($this->oxcategories__oxextlink) && $this->oxcategories__oxextlink->value) {
- return oxRegistry::get("oxUtilsUrl")->processUrl($this->oxcategories__oxextlink->value, false);
+ return oxRegistry::get("oxUtilsUrl")->processUrl($this->oxcategories__oxextlink->value, true);
}
if ($iLang === null) {
@@ -490,7 +490,7 @@ public function testGetStdLinkShouldReturnExtLink()
$oCategory = oxNew('oxCategory');
$oCategory->oxcategories__oxextlink = new oxField('xxx', oxField::T_RAW);
- $this->assertEquals('xxx?', $oCategory->getStdLink());
+ $this->assertEquals('xxx', $oCategory->getStdLink());
}
public function testGetStdLinkshoudlReturnDefaultLink()
@@ -521,7 +521,7 @@ public function testGetLinkWithExtLink()
$oCategory = oxNew('oxCategory');
$oCategory->oxcategories__oxextlink = new oxField('www.test.com', oxField::T_RAW);
- $this->assertEquals('www.test.com?', $oCategory->getLink());
+ $this->assertEquals('www.test.com', $oCategory->getLink());
}
public function testGetLinkSeoDe()
@@ -565,7 +565,7 @@ public function testGetStdLinkShouldReturnExtLinkWithLangParam()
$oCategory = oxNew('oxCategory');
$oCategory->oxcategories__oxextlink = new oxField('xxx', oxField::T_RAW);
- $this->assertEquals('xxx?', $oCategory->getStdLink(2));
+ $this->assertEquals('xxx', $oCategory->getStdLink(2));
}
public function testGetStdLinkshoudlReturnDefaultLinkWithLangParam()

0 comments on commit 2107529

Please sign in to comment.