Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding monolog as the default logger to OXID #601
There are really awesome libraries for application logging in PHP, and as OXID does not use one of them, i thought it's about time. I stopped reworking everything logging at the
@flow-control I also love to see built a built in logger support. Thank you for your pull requestest. One idea to improve your code: the core Logger class is not needed, it is substituted with monolog anyway, and would need a loggerimpl. to be functional.
I feel the same way about that core logger class, but it's done in a similar way as the database layer. Someone told me that this is done in case you ever ditch doctrine. If we agree on the psr3 interface, than of course this argument back than would be invalid. So you are right, I will remove it. What's your opinion on the exception classes, should I refactor those to use the new logger, or should that be kept open for another PR?
@flow-control that is very difficult question for me, I did similar pull request in the past with monolog configuration file and configurable exception handler, dependency injection and unittests and it grown to big for me to maintain it over a long a time while core team was refactoring for version 6.
2 similar comments
2 times, most recently
Feb 8, 2018
added a commit
this pull request
Apr 17, 2018
As already mentioned by @Sieg, the core team will merge your pull request soon. Thank you for that! We decided to have some things on top (everyting fine with your pull request):
The core team will implement those changes soon.