Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read config parameter by getConfigParam, not by getRequestParam. #698

Closed

Conversation

Projects
None yet
2 participants
@michaelkeiluweit
Copy link
Contributor

commented Apr 8, 2019

By calling getRequestParam('blVariantSelection') we will always get null, as this request is never made and leads to this bug: https://bugs.oxid-esales.com/view.php?id=6968

michaelkeiluweit added some commits Apr 8, 2019

By calling ->getRequestParam('blVariantSelection') we will always get…
… null, as this request is never made and leads to this bug: https://bugs.oxid-esales.com/view.php?id=6968

I replaced the call with the method getConfigParam, like it is in the other Ajax methods done. After that the variants are shown in the manufactor popup list, too.

@michaelkeiluweit michaelkeiluweit changed the title Read config parameter by getConfigParam, not by getRequestParam. WIP: Read config parameter by getConfigParam, not by getRequestParam. Apr 9, 2019

@michaelkeiluweit michaelkeiluweit changed the title WIP: Read config parameter by getConfigParam, not by getRequestParam. Read config parameter by getConfigParam, not by getRequestParam. Apr 9, 2019

@Sieg

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

Hi @michaelkeiluweit, yah, i have fixed that one already. Merged to b-6.1.x (c68b9a0). Thanks!

@Sieg Sieg closed this Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.