Make setSessionCookie protected, correct _sessionStart regression #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the setSessionCookie function protected, so that modules that extend Session can modify the parameters passed to setOxCookie, for example to change the session lifetime. Correct a regression in _sessionStart between master and b-6.2.x, where some redundant code that is removed in master has reappeared. See lines 313-318 in https://github.com/OXID-eSales/oxideshop_ce/blob/master/source/Core/Session.php See lines 312-329 in https://github.com/OXID-eSales/oxideshop_ce/blob/b-6.2.x/source/Core/Session.php
Sieg
pushed a commit
that referenced
this pull request
Apr 1, 2020
Fixes _sessionStart regression Make the setSessionCookie function protected, so that modules that extend Session can modify the parameters passed to setOxCookie, for example to change the session lifetime. Related #785
Sieg
added a commit
that referenced
this pull request
Apr 1, 2020
|
Many thanks @Sieg and @flow-control . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the requested changes and replaces PR #782. It also corrects a regression.
Make the setSessionCookie function protected, so that modules that extend Session can modify the parameters passed to setOxCookie, for example to change the session lifetime.
Add a standard comment header to setSessionCookie.
Correct a regression in _sessionStart between master and b-6.2.x, where some redundant code that is removed in master has reappeared.
See lines 313-318 in
https://github.com/OXID-eSales/oxideshop_ce/blob/master/source/Core/Session.php
See lines 312-329 in
https://github.com/OXID-eSales/oxideshop_ce/blob/b-6.2.x/source/Core/Session.php