Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overwriting offline.html when installing package. #17

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@icedream
Copy link
Contributor

commented Sep 3, 2019

For some shops it may be desirable to be able to change the HTML page that is displayed if and when the shop becomes unavailable. Since there is no way to configure the path of the HTML file to be displayed, it is necessary to edit the existing offline.html for this. Unfortunately, currently a composer install would overwrite the offline.html file even if it already exists.

This patch is supposed to fix this issue by treating offline.html the same way as .htaccess in that it is only installed if it has not been provided already.

This patch is currently missing tests.

Sieg added a commit that referenced this pull request Sep 5, 2019

@Sieg Sieg merged commit 05bb523 into OXID-eSales:master Sep 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Sieg

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

Thank you @icedream for the improvement. Yes, you are right, the offline page should be handled the same way as .htaccess and other not extendable files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.