Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify checkout step 2 (user registration) #68

Open
wants to merge 12 commits into
base: master
from

Conversation

@martin-hofer
Copy link
Contributor

commented Aug 15, 2019

We propose a simplification of step 2 of the checkout process. Instead of showing the three "checkout columns" and thus requiring an additional click by the user, the registration/noregistration form is displayed right next to the login. Differentiation between registration and noregistration happens by means of a toggling checkbox (works the same way as the checkbox for a separate shipping adress).

Before:
image

After:
image
image

Additionally, the newsletter checkbox and the remark textarea were given a separate card, because that makes much more sense than having them in the acount and/or shipping address cards (this is currently also a bit inconsistent between "change address" and the "register" form).

Before:
image
image

After:
image

(By the way, thanks to Aggrosoft for the inspiration)

martin-hofer and others added 9 commits Jul 20, 2019
Update to Wave 1.2.0
Wave-Update
Sync with master
* Remove register options, make one page. left side registration, right side login
* Moved orderRemark from the shipping address form to its own card element
* Moved newsletter checkbox into the same card element as the remark textarea
@martin-hofer martin-hofer marked this pull request as ready for review Aug 15, 2019
@@ -1,6 +1,6 @@
[{oxscript include="js/libs/jqBootstrapValidation.min.js" priority=10}]
[{oxscript add="$('input,select,textarea').not('[type=submit]').jqBootstrapValidation();"}]
<div class="card">
<div class="card" style="height:auto">

This comment has been minimized.

Copy link
@KristianH

KristianH Aug 16, 2019

Please use a css class or an id, but no inline css.

This comment has been minimized.

Copy link
@martin-hofer

martin-hofer Aug 16, 2019

Author Contributor

Are you sure? This is only necessary in this one, very specific instance. I didn't want to clutter the main CSS file with it.

Or would it be OK to put it into an oxstyle block at the beginning of the .tpl file?

This comment has been minimized.

Copy link
@KristianH

KristianH Aug 16, 2019

my opinion: It is bad practice.
try to in the theme css files, if there is a already defined class, with the required style.

This comment has been minimized.

Copy link
@martin-hofer

martin-hofer Aug 16, 2019

Author Contributor

Alright, it is done ;-)

I also removed user_checkout_noregistration.tpl, since this checkout workflow doesn't need it any more.

Feature/better checkout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.