Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the card framework #21

Open
sbegaudeau opened this issue Nov 6, 2017 · 1 comment
Open

Refactor the card framework #21

sbegaudeau opened this issue Nov 6, 2017 · 1 comment
Assignees

Comments

@sbegaudeau
Copy link
Member

The card framework needs to be re-organize with one component per file and we will need to rethink some of those components (do we really need a body and footer instead of more specific blocks?)

@sbegaudeau sbegaudeau self-assigned this Nov 6, 2017
@sbegaudeau
Copy link
Member Author

We should also properly define the API of the components with their propTypes. As an example, what kind of events should be available on ItemText? What kind of API should be available to WorkflowSectionCard and what kind of API should WorkflowSectionCard offer? (onClick, handleClick, etc?)

Define a proper naming convention for the events of our components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant