Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement activity partition #371

Open
mbats opened this issue Dec 4, 2013 · 6 comments
Open

Implement activity partition #371

mbats opened this issue Dec 4, 2013 · 6 comments

Comments

@mbats
Copy link
Member

mbats commented Dec 4, 2013

Activity partition are missing.
See : http://www.uml-diagrams.org/activity-diagrams.html

mbats added a commit that referenced this issue Apr 17, 2014
@mbats
Copy link
Member Author

mbats commented Apr 17, 2014

See branch compartments.

  • It should be possible to create vertical or horizontal regions depending on where the user create the second region. If he creates the second region East or West form the first one we will expect horizontal stack for the regions, else if he creates it North or South, it will be a vertical stack of regions.
  • There is also a small problem with the rounded corner of the container and the activity partitions that go over their container.

image

@mbats
Copy link
Member Author

mbats commented Apr 17, 2014

Related to ticket : https://support.jira.obeo.fr/browse/VP-573

@mbats mbats modified the milestones: 4.0.0, 4.0.0_M3 Apr 17, 2014
@mbats mbats modified the milestones: 4.1.0, 4.0.0 Apr 30, 2014
@mbats mbats modified the milestones: 5.0.0, 4.1.0 Jun 11, 2014
@mPorhel
Copy link
Contributor

mPorhel commented Feb 10, 2015

"There is also a small problem with the rounded corner of the container and the activity partitions that go over their container."

On #376 you do not have this problem: I think you enabled the rounded corner and put the same corner size.

See 376 for ideas on the correction.

@mbats mbats modified the milestones: 5.0.0, 6.0.0 Apr 2, 2015
@mbats
Copy link
Member Author

mbats commented May 12, 2015

@mPorhel
Copy link
Contributor

mPorhel commented Jun 24, 2015

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=470770 for the rounded corner issue. If the compartment mapping does not have a style with rounded corner, Sirius should draw the bottom corner of the last (vertical stack, first and last for horizontal stack) as rounded.

@mPorhel
Copy link
Contributor

mPorhel commented Jun 24, 2015

It should be possible to create vertical or horizontal regions depending on where the user create the
second region. If he creates the second region East or West form the first one we will expect horizontal
stack for the regions, else if he creates it North or South, it will be a vertical stack of regions.

The children presentation attribute is set on the region container mapping (and not on the style).
If you want to used different mapping regarding the location of the second compartment creation click, your tool might have to put some information in the model to let Sirius choose the good mapping. An other idea would be to improve the style customization mecanism to allow mapping customization as well.

@mbats mbats modified the milestones: 6.0.0, 6.1.0 Oct 19, 2015
@mbats mbats modified the milestones: 7.1.0, 7.0.0 Jul 28, 2016
@mbats mbats modified the milestones: 7.2.0, 8.0.0 Dec 2, 2016
@mbats mbats modified the milestones: 8.0.0, 9.0.0 Jul 25, 2017
@mbats mbats modified the milestones: 9.0.0, 8.0.0 Jul 25, 2017
@mbats mbats removed this from the 9.0.0 milestone May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants